Skip to content

Conversation

@msiebeneicher
Copy link
Contributor

Description

Close #236

This PR enables you to change the commit message in the created pull request

Copy link
Owner

@AndreasAugustin AndreasAugustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @msiebeneicher thank you very much for you PR.
All fine, just would be nice if you could add a check at script start if the variable is set, e.q.

if [[ -z "${PR_COMMIT_MSG}" ]]; then
  echo "::error::Missing env variable 'PR_COMMIT_MSG'" >&2;
  exit 1;
fi

just to make sure that it fails soon enough if the message is missing.

@AndreasAugustin AndreasAugustin added documentation Improvements or additions to documentation enhancement New feature or request labels Dec 9, 2022
@msiebeneicher
Copy link
Contributor Author

Hi @msiebeneicher thank you very much for you PR. All fine, just would be nice if you could add a check at script start if the variable is set, e.q.

if [[ -z "${PR_COMMIT_MSG}" ]]; then
  echo "::error::Missing env variable 'PR_COMMIT_MSG'" >&2;
  exit 1;
fi

just to make sure that it fails soon enough if the message is missing.

Added the check :)

Copy link
Owner

@AndreasAugustin AndreasAugustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 thanks a lot!

@AndreasAugustin
Copy link
Owner

@all-contributors please add @msiebeneicher for code

@allcontributors
Copy link
Contributor

@AndreasAugustin

I've put up a pull request to add @msiebeneicher! 🎉

@AndreasAugustin AndreasAugustin merged commit 764e725 into AndreasAugustin:main Dec 12, 2022
@msiebeneicher msiebeneicher deleted the feat/make_commit_msg_configurable branch December 12, 2022 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add possibility to change the used commit msg

2 participants