-
-
Notifications
You must be signed in to change notification settings - Fork 51
feat: make commit msg configurable #237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make commit msg configurable #237
Conversation
AndreasAugustin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @msiebeneicher thank you very much for you PR.
All fine, just would be nice if you could add a check at script start if the variable is set, e.q.
if [[ -z "${PR_COMMIT_MSG}" ]]; then
echo "::error::Missing env variable 'PR_COMMIT_MSG'" >&2;
exit 1;
fijust to make sure that it fails soon enough if the message is missing.
Added the check :) |
AndreasAugustin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 thanks a lot!
|
@all-contributors please add @msiebeneicher for code |
|
I've put up a pull request to add @msiebeneicher! 🎉 |
Description
Close #236
This PR enables you to change the commit message in the created pull request