Skip to content

Conversation

@adamsitnik
Copy link

this is my pedantic proposal to dotnet#174

When I was porting all the benchmarks to perf repo I realized that most of them have very long names, which are used as IDs in BenchView and don't look good in the web browser.

Before:

GuardedDevirtualizationThreeClass.Virtual.Call3
GuardedDevirtualizationThreeClassInterface.Interface.Call3
GuardedDevirtualizationTwoClass.Virtual.Call2
GuardedDevirtualizationTwoClassInterface.Interface.Call2

After:

GuardedDevirtualization.ThreeClassVirtual.Call
GuardedDevirtualization.ThreeClassInterface.Call
GuardedDevirtualization.TwoClassVirtual.Call
GuardedDevirtualization.TwoClassInterface.Call

Also instead of using Random we can use a ValuesGenerator which was added to perf repo to avoid common issues when working with random input.

@AndyAyersMS this PR is very subjective, if you don't like the changes please close it and I am going to merge dotnet#174 without it immediately.

@AndyAyersMS
Copy link
Owner

I didn't like the long names either so am happy to see them get shorter.

@AndyAyersMS AndyAyersMS merged commit ab6192f into AndyAyersMS:GuardedDevirtTests Dec 12, 2018
@adamsitnik adamsitnik deleted the minorPedanticChanges branch March 4, 2019 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants