fix(worker): surface build failure error in frontend logs (fixes #1984)#1997
fix(worker): surface build failure error in frontend logs (fixes #1984)#1997octo-patch wants to merge 2 commits intoAndyMik90:developfrom
Conversation
…yMik90#1977) Without min-h-0 on the flex container, the default flex min-height is 'auto', allowing the child to grow beyond its parent's bounds. This causes the ScrollArea to also grow unconstrained, making the Insights panel scroll off the top of the screen after messages load.
When a pre-QA failure occurred (e.g. stream inactivity timeout), only
postTaskEvent('CODING_FAILED') was called with no corresponding postError(),
so the error message never appeared in the task's Logs tab — the task
silently transitioned to Human Review with no explanation.
Add a postError() call before CODING_FAILED so the error is written to
the task log and visible to the user.
Fixes AndyMik90#1984
Co-Authored-By: Octopus <liyuan851277048@icloud.com>
|
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe changes add error reporting to build orchestration when planning or coding failures occur, emitting error messages to the frontend before posting task failure events. Additionally, a layout styling fix improves the flex container behavior in the Insights chat area. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request improves error reporting in the build orchestrator by explicitly posting error messages when a pre-QA failure occurs. Additionally, it applies a CSS layout fix to the Insights component by adding "min-h-0" to the main chat area to prevent potential flexbox overflow issues. I have no feedback to provide.
Summary
postTaskEvent('CODING_FAILED')was called without any precedingpostError()callpostError()call beforeCODING_FAILEDso the error (e.g. "Stream inactivity timeout — no data received from provider for 60s") appears in the task's Logs tabRoot Cause
In
apps/desktop/src/main/ai/agent/worker.ts, the pre-QA failure branch only emitted the XState machine event but skipped the log channel:Fix
Test Plan
Fixes #1984
Summary by CodeRabbit