fix(event): Differentiate WindowOpened and WindowChanged#35
Merged
Antiz96 merged 2 commits intoAntiz96:mainfrom Apr 21, 2026
Merged
fix(event): Differentiate WindowOpened and WindowChanged#35Antiz96 merged 2 commits intoAntiz96:mainfrom
Antiz96 merged 2 commits intoAntiz96:mainfrom
Conversation
We can differentiate if a window is being opened or a window's state has changed by checking if the window is already in the same workspace. If it is, we know the window state just changed, and we can skip processing the whole event. Signed-off-by: Eric Naim <dnaim@cachyos.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
So, after waking up I thought of this more elegant solution for the Nautilus hack, and in turn this fixes a bug that oniri has as well, namely: If a single window is not maximized, then a state change (window title changing) can maximize that window.
Screenshots / Logs
Fixed bug
Fixes "issue_URL" (if any)
Addressed feature request
Closes "issue_URL" (if any)