-
Notifications
You must be signed in to change notification settings - Fork 97
refactor: organize the import and export of SparseModel #141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hey @honsunrise. Thanks for the contribution.
Fine by me. |
7e4ebbd to
c1415cd
Compare
|
Hey @honsunrise. Thank you. |
Hey @Anush008. Thank for your review. Yes, There has two breaking changes:
For the first breaking change, if we want to unify ModelInfo to achieve a consistent and clean API, this might be the best approach I can think of. |
|
We cannot have breaking changes unless itss a major release though. |
Can we consider this PR as part of a major release? |
I rolled back all the breaking changes and moved them to a new PR. |
c1415cd to
4497fae
Compare
4497fae to
dff7f02
Compare
|
Anush008
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for contributing @honsunrise. LGTM!
# [4.5.0](v4.4.0...v4.5.0) (2025-02-18) ### Features * Add modernbert-embed-large ([#146](#146)) ([8184799](8184799)) ## [4.5.0](v4.4.0...v4.5.0) (2025-02-18) ### 🍕 Features * Add modernbert-embed-large ([#146](#146)) ([8184799](8184799)) ### 🧑💻 Code Refactoring * organize the import and export of SparseModel ([#141](#141)) ([2f982f1](2f982f1)) ### 🧹 Chores * Bump hf-hub to 0.4.1 ([#142](#142)) ([b5911b4](b5911b4))
|
🎉 This PR is included in version 4.5.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Hi @Anush008,
Additionally, I'm not quite clear on your thoughts. Perhaps we could move the
RerankerModelInfofromcrate::models::rerankingtocrate::models::model_info.If you think this aligns with your design, then I can add a commit into this PR or open a new PR.