Conversation
Member
martincostello
left a comment
There was a problem hiding this comment.
Any tests we can add/extend to verify stack traces don't get lost?
Codecov Report
@@ Coverage Diff @@
## main #1319 +/- ##
=======================================
Coverage 83.37% 83.37%
=======================================
Files 264 268 +4
Lines 6333 6335 +2
Branches 1001 1001
=======================================
+ Hits 5280 5282 +2
Misses 844 844
Partials 209 209
Flags with carried forward coverage won't be shown. Click here to find out more.
|
martincostello
approved these changes
Jun 19, 2023
|
|
||
| public EventInvoker<OnHedgingArguments>? OnHedging { get; } | ||
|
|
||
| [ExcludeFromCodeCoverage] // coverlet issue |
Member
There was a problem hiding this comment.
Is there a specific issue we could link to?
Contributor
Author
There was a problem hiding this comment.
This one for example;
coverlet-coverage/coverlet#1284
There are more of those related to await handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details on the issue fix or feature implementation
Fixes and improvements based on some testing and playing with the alpha1 package.
CancellationTokenSourcetoo lateResultFormatternot being used for resilience events.<Strategy>PredicateArgumentspattern. The delegate's name is alwaysShouldHandle.ShouldHandlecallback for fallback.Contributes to #1301
Confirm the following