Conversation
martincostello
approved these changes
Jun 27, 2023
| <ItemGroup Condition="!$([MSBuild]::IsTargetFrameworkCompatible($(TargetFramework), 'netcoreapp3.1'))"> | ||
| <PackageVersion Include="Microsoft.Extensions.Options" Version="2.2.0" /> | ||
| <PackageVersion Include="Microsoft.Extensions.Logging.Abstractions" Version="2.2.0" /> | ||
| <PackageVersion Include="Microsoft.Extensions.Logging.Abstractions" Version="6.0.0" /> |
Member
There was a problem hiding this comment.
This won't cause an issue for any of the older TFMs?
Contributor
Author
There was a problem hiding this comment.
It shouldn't and if we find so it will be fixed in 8.0.0 version that we will reference on every TFM anyway.
Codecov Report
@@ Coverage Diff @@
## main #1359 +/- ##
=======================================
Coverage 83.51% 83.51%
=======================================
Files 268 268
Lines 6362 6362
Branches 999 999
=======================================
Hits 5313 5313
Misses 840 840
Partials 209 209
Flags with carried forward coverage won't be shown. Click here to find out more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details on the issue fix or feature implementation
I am dropping some #ifdef for older framework since in #1144 we are unifying the package dependencies anyway.
Confirm the following