Add new metering tests to cover uncovered lines#1474
Merged
Conversation
martincostello
approved these changes
Aug 10, 2023
Member
|
Would this maybe explain that random 99.75% coverage failure we get sometimes? Or is this something entirely new/different? |
Codecov Report
@@ Coverage Diff @@
## main #1474 +/- ##
=======================================
Coverage 83.88% 83.88%
=======================================
Files 275 275
Lines 6492 6492
Branches 1015 1015
=======================================
Hits 5446 5446
Misses 837 837
Partials 209 209
Flags with carried forward coverage won't be shown. Click here to find out more. |
Contributor
Author
It was revealed on .NET 8 so it's possible that this affected also .NET 7 and lower. Anyway let's see, this change can only help. |
This was referenced Sep 29, 2025
This was referenced Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details on the issue fix or feature implementation
Noticed this in #1144.
Confirm the following