Drop unused ResiliencePipelineRegistry APIs#1495
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1495 +/- ##
==========================================
- Coverage 83.64% 83.59% -0.05%
==========================================
Files 268 268
Lines 6394 6377 -17
Branches 1007 1007
==========================================
- Hits 5348 5331 -17
Misses 837 837
Partials 209 209
Flags with carried forward coverage won't be shown. Click here to find out more.
|
martincostello
approved these changes
Aug 17, 2023
This was referenced Sep 29, 2025
This was referenced Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details on the issue fix or feature implementation
This makes the registry append-only.
One reason the removals might not be required is the built-in dynamic reload support. Instead of removing, re-creating and adding the pipeline back, it's cleaner and safer to just tell the registry to reload the pipeline.
If there is a feature request for it, we can add these APIs easily back.
Contributes to #1233
Confirm the following