Skip to content

Conversation

@martintmk
Copy link
Contributor

@martintmk martintmk commented Sep 8, 2023

Details on the issue fix or feature implementation

Contributes to #1091

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label Sep 8, 2023
@martintmk martintmk added this to the v8.0.0 milestone Sep 8, 2023
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.01% 🎉

Comparison is base (f6a248f) 83.92% compared to head (f4c53ee) 83.93%.
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1575      +/-   ##
==========================================
+ Coverage   83.92%   83.93%   +0.01%     
==========================================
  Files         279      279              
  Lines        6520     6525       +5     
  Branches     1017     1019       +2     
==========================================
+ Hits         5472     5477       +5     
  Misses        839      839              
  Partials      209      209              
Flag Coverage Δ
linux ?
macos 83.93% <ø> (+0.01%) ⬆️
windows 83.93% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/Polly.Core/Registry/ConfigureBuilderContext.cs 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

| `InstanceNameFormatter` | `null` | Function formatting `TKey` to instance name. |
| `BuilderNameFormatter` | Function returning the `key.ToString()` value. | Function formatting `TKey` to builder name. |
| `InstanceNameFormatter` | `null` | Delegate formatting `TKey` to instance name. |
| `BuilderNameFormatter` | Function returning the `key.ToString()` value. | Delegate formatting `TKey` to builder name. |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| `BuilderNameFormatter` | Function returning the `key.ToString()` value. | Delegate formatting `TKey` to builder name. |
| `BuilderNameFormatter` | A delegate returning the `key.ToString()` value. | Delegate formatting `TKey` to builder name. |

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v8 Issues related to the new version 8 of the Polly library.

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants