Skip to content

Hide Simmy API for initial v8 release#1601

Merged
martintmk merged 1 commit intomainfrom
hide-simmy-api
Sep 20, 2023
Merged

Hide Simmy API for initial v8 release#1601
martintmk merged 1 commit intomainfrom
hide-simmy-api

Conversation

@martintmk
Copy link
Contributor

Details on the issue fix or feature implementation

This PR hides API introduced by #1459.

The reason for this is that current API is already reviewed and Polly v8 is to be released soon after #1091 is done.
Once #1571 is approved we can unhide the API and release it in 8.1

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label Sep 20, 2023
@martintmk martintmk added this to the v8.0.0 milestone Sep 20, 2023
@martintmk martintmk mentioned this pull request Sep 20, 2023
17 tasks
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (7cc2ea1) 84.63% compared to head (fe99ffb) 84.63%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1601   +/-   ##
=======================================
  Coverage   84.63%   84.63%           
=======================================
  Files         306      306           
  Lines        6820     6820           
  Branches     1044     1044           
=======================================
  Hits         5772     5772           
  Misses        839      839           
  Partials      209      209           
Flag Coverage Δ
linux ?
macos 84.63% <ø> (ø)
windows 84.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...lly.Core/Simmy/Behavior/BehaviorActionArguments.cs 100.00% <ø> (ø)
...immy/Behavior/BehaviorPipelineBuilderExtensions.cs 100.00% <ø> (ø)
...lly.Core/Simmy/Behavior/BehaviorStrategyOptions.cs 100.00% <ø> (ø)
...Core/Simmy/Behavior/OnBehaviorInjectedArguments.cs 100.00% <ø> (ø)
src/Polly.Core/Simmy/EnabledGeneratorArguments.cs 100.00% <ø> (ø)
...olly.Core/Simmy/InjectionRateGeneratorArguments.cs 100.00% <ø> (ø)
...ly.Core/Simmy/Latency/LatencyGeneratorArguments.cs 100.00% <ø> (ø)
.../Simmy/Latency/LatencyPipelineBuilderExtensions.cs 100.00% <ø> (ø)
...Polly.Core/Simmy/Latency/LatencyStrategyOptions.cs 100.00% <ø> (ø)
src/Polly.Core/Simmy/Latency/OnLatencyArguments.cs 100.00% <ø> (ø)
... and 11 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martintmk
Copy link
Contributor Author

cc @vany0114

Copy link
Contributor

@vany0114 vany0114 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 I'll work thru the #1571 feedback and also this comment as soon as I can.

@martintmk martintmk merged commit 2c3f74b into main Sep 20, 2023
@martintmk martintmk deleted the hide-simmy-api branch September 20, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v8 Issues related to the new version 8 of the Polly library.

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants