Skip to content

Add antipatterns to fallback strategy#1607

Merged
martintmk merged 2 commits intoApp-vNext:mainfrom
peter-csala:add-antipatterns-to-fallback-strategy
Sep 21, 2023
Merged

Add antipatterns to fallback strategy#1607
martintmk merged 2 commits intoApp-vNext:mainfrom
peter-csala:add-antipatterns-to-fallback-strategy

Conversation

@peter-csala
Copy link
Contributor

The issue or feature being addressed

Details on the issue fix or feature implementation

  • I've migrated the V7 example codes to V8
  • I've extended the fallback.md with patterns and anti-patterns section

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (83700e8) 84.63% compared to head (20ba314) 84.63%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1607   +/-   ##
=======================================
  Coverage   84.63%   84.63%           
=======================================
  Files         306      306           
  Lines        6820     6820           
  Branches     1044     1044           
=======================================
  Hits         5772     5772           
  Misses        839      839           
  Partials      209      209           
Flag Coverage Δ
linux 84.63% <ø> (ø)
macos 84.63% <ø> (ø)
windows 84.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martintmk martintmk enabled auto-merge (squash) September 21, 2023 13:51
@martintmk martintmk merged commit 8241fc4 into App-vNext:main Sep 21, 2023
@martincostello martincostello added the v8 Issues related to the new version 8 of the Polly library. label Sep 26, 2023
@martincostello martincostello added this to the v8.0.0 milestone Sep 26, 2023
@peter-csala peter-csala deleted the add-antipatterns-to-fallback-strategy branch October 31, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v8 Issues related to the new version 8 of the Polly library.

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants