Merged
Conversation
Apply some grammar and wording changes to the documentation for v8.
martincostello
added
documentation
v8
Update grammar/wording for MaxDelay.
martintmk
reviewed
Sep 26, 2023
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1630 +/- ##
=======================================
Coverage 84.63% 84.63%
=======================================
Files 306 306
Lines 6819 6819
Branches 1045 1045
=======================================
Hits 5771 5771
Misses 839 839
Partials 209 209
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Fix some grammar and spelling.
Tweak some wording and snippets.
Apply some grammar changes.
- Tweak some grammar. - Add links to concepts.
Update some grammar and links.
Apply some further refinements and links to the docs.
martintmk
reviewed
Sep 27, 2023
martintmk
approved these changes
Sep 27, 2023
Contributor
martintmk
left a comment
martintmk
left a comment
There was a problem hiding this comment.
Outside of that capitalization thing it looks good! Great job :)
Revert usage of title case in headings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply some grammar and wording changes to the documentation for v8.
I'm slowly making my way through the PRs from while I was on holiday and making edits that I would have suggested via PR review. Once I've caught up and move this out of draft for review.