-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Fix retry overflow with max delay #1868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix retry overflow with max delay #1868
Conversation
|
@dotnet-policy-service agree |
martincostello
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one minor suggestion.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1868 +/- ##
=======================================
Coverage 84.58% 84.59%
=======================================
Files 308 308
Lines 6799 6801 +2
Branches 1049 1050 +1
=======================================
+ Hits 5751 5753 +2
Misses 839 839
Partials 209 209
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Pull Request
The issue or feature being addressed
Fix issue #1866 Retry Startegy stops retrying unexpectedly
Details on the issue fix or feature implementation
In case computing retry delay throws
OverflowException,RetryHelper.GetRetryDelay(...)returnsmaxDelay.valueif not null,TimeSpan.MaxValueotherwise.Confirm the following