Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1888 +/- ##
=======================================
Coverage 84.66% 84.66%
=======================================
Files 309 309
Lines 6836 6836
Branches 1052 1052
=======================================
Hits 5788 5788
Misses 839 839
Partials 209 209
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@martintmk I noticed that the documentation of the property wasn't updated in this PR, it still states that the minimum is (above) 1 second. On another note, is there a reason why the maximum value is 24 hours? |
|
When we picked an upper limit, a day seemed a reasonable upper limit considering that is effectively millennia to a computer. Having a thread trying to perform a single operation through Polly for up to an entire day seems on the extreme end for a thing for code to try and do, and we need to draw a line somewhere. Do you have a use case where you need a single method invocation to run for more than 24 hours, but still need to eventually timeout? |
Pull Request
The issue or feature being addressed
Closes #1884
Details on the issue fix or feature implementation
Relaxing the min allowed timeout to 10ms. (from 1 second)
Confirm the following