Skip to content

[Bug] Fix chaos outcome exception handling #2101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martintmk merged 8 commits into from
May 10, 2024
Merged

[Bug] Fix chaos outcome exception handling #2101

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6693095
Replace public properties to private fields
peter-csala May 9, 2024
e34a9c2
Throw exception if needed
peter-csala May 9, 2024
221da2b
Fix build
peter-csala May 9, 2024
7d11148
Fix build
peter-csala May 9, 2024
8832da8
Handle each outcome case explicitly
peter-csala May 10, 2024
a17a644
Fix sonar rule violation
peter-csala May 10, 2024
1f0a4d1
Apply suggestion
peter-csala May 10, 2024
d689f14
Fix .net481 support
peter-csala May 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/Polly.Core/Simmy/Outcomes/ChaosOutcomeStrategy.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,17 @@ protected internal override async ValueTask<Outcome<T>> ExecuteCore<TState>(Func
await _onOutcomeInjected(args).ConfigureAwait(context.ContinueOnCapturedContext);
}

if (outcome.Value.Exception is not null)
if (outcome.HasValue is false)
{
return new Outcome<T>(outcome.Value.Exception);
return new Outcome<T>(default(T?));
}

return new Outcome<T>(outcome.Value.Result);
if (outcome.Value.HasResult)
{
return new Outcome<T>(outcome.Value.Result);
}

return new Outcome<T>(outcome.Value.Exception!);
}

return await StrategyHelper.ExecuteCallbackSafeAsync(callback, context, state).ConfigureAwait(context.ContinueOnCapturedContext);
Expand Down