-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Supress S4039, CA1010 in Context.Dictionary #2329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2e249ab to
595e3ad
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2329 +/- ##
=======================================
Coverage 85.40% 85.40%
=======================================
Files 313 313
Lines 7467 7467
Branches 1126 1126
=======================================
Hits 6377 6377
Misses 745 745
Partials 345 345
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
martincostello
approved these changes
Oct 7, 2024
This was referenced Jul 30, 2025
This was referenced Aug 18, 2025
This was referenced Sep 2, 2025
This was referenced Sep 22, 2025
This was referenced Sep 29, 2025
This was referenced Oct 9, 2025
Closed
This was referenced Oct 20, 2025
This was referenced Nov 3, 2025
This was referenced Nov 24, 2025
Open
This was referenced Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
The issue or feature being addressed
Related issue #1290
Details on the issue fix or feature implementation
Reason for supressing S4039: Same as existing supression CA1033, reason refers to PR #2193.
Reason for supressing CA1010: Fixing this warning requires removing implementation for IDictionary, implement only the generic type
IDictionary<string, object>, which would be a breaking change, so supress it.Confirm the following