Skip to content

Fix flaky test #2457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martincostello merged 2 commits into from
Jan 18, 2025
Merged

Fix flaky test #2457

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
afeb9b5
Fix flaky test
martincostello Jan 18, 2025
5a12054
Increase timeout
martincostello Jan 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Increase timeout 
Increase timeout on test.
  • Loading branch information
@martincostello
martincostello committed Jan 18, 2025
commit 5a120544debcc592576f6f355523b8edbfe2126c
5 changes: 3 additions & 2 deletions test/Polly.Core.Tests/Issues/IssuesTests.InfiniteRetry_2163.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ namespace Polly.Core.Tests.Issues;

public partial class IssuesTests
{
[Fact(Timeout = 15_000)]
[Fact(Timeout = 30_000)]
public async Task InfiniteRetry_Delay_Does_Not_Overflow_2163()
{
// Arrange
Expand Down Expand Up @@ -35,7 +35,8 @@ public async Task InfiniteRetry_Delay_Does_Not_Overflow_2163()
var strategy = new RetryResilienceStrategy<bool>(options, timeProvider, telemetry);
var pipeline = strategy.AsPipeline();

using var cts = new CancellationTokenSource(Debugger.IsAttached ? TimeSpan.MaxValue : TimeSpan.FromSeconds(10));
using var cts = new CancellationTokenSource(
Debugger.IsAttached ? TimeSpan.MaxValue : TimeSpan.FromSeconds(20));

// Act
var executing = pipeline.ExecuteAsync((_) =>
Expand Down
Loading