-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Fix chaos example issue and enrich notes & diagram #2482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
aee0386
Fix chaos doc example issue and enrich notes on index.md
caigen 8cadca3
Fix Snippets
caigen b4dbda3
Update chaos injection rates and comments
caigen 77afbd5
Fix typo and formatting in chaos strategy note
caigen e25f060
Update behavior injection rate and add diagram
caigen dff729d
Update chaos injection comments for clarity
caigen a201d4a
Add note on chaos strategy order.
caigen 725ced2
Update chaos strategy notes in documentation
caigen 52c3134
Update docs/chaos/index.md
caigen 92f69d8
Fix note formatting in chaos strategy documentation
caigen bc56807
Remove note formatting in chaos documentation
caigen e5ac3f8
Fix formatting in chaos strategy documentation
caigen 245ca26
Update chaos strategy documentation with notes
caigen a9e5e10
Fix spacing
martincostello a99c2cd
Fix lint warning
martincostello 64ddacc
Apply suggestions from code review
martincostello 35dca07
Remove mermaid diagram
martincostello File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix spacing
Make markdownlint happy.
- Loading branch information
commit a9e5e10b87cb76be96e4feb19a7ecc40a966a36d
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -47,11 +47,12 @@ | |
| .AddChaosBehavior(behaviorInjectionRate, cancellationToken => RestartRedisAsync(cancellationToken)); // Inject a chaos behavior to executions | ||
| ``` | ||
| <!-- endSnippet --> | ||
|
|
||
| > [!NOTE] | ||
martincostello marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| > It is usual to place the chaos strategy as the last strategy in the resilience pipeline. | ||
| > By placing the chaos strategies as last, they subvert the usual outbound call at the last minute, substituting their fault or adding extra latency, etc. | ||
| > The existing resilience strategies - further out in the `ResiliencePipeline` - still apply, so you can test how the Polly resilience strategies you have configured handle the chaos/faults injected by Simmy. | ||
|
|
||
|
Check failure on line 55 in docs/chaos/index.md
|
||
| > [!NOTE] | ||
| > The `AddChaosFault` `AddChaosLatency` `AddChaosOutcome` `AddChaosBehavior` will take effect sequentially if you combine them together. | ||
| > In the above example, we use **fault first then latency strategy**, it can save fault waiting time. If you put `AddChaosLatency` before `AddChaosFault`, you will get different behavior. | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.