-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Lint PowerShell scripts #2504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lint PowerShell scripts #2504
Conversation
- Add a PowerShell linter. - Fix PowerShell lint warnings. - Update actionlint to v1.7.7.
- Fix PowerShell lint warnings in workflows.
- Use `${env:}` for consistency.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2504 +/- ##
=======================================
Coverage 85.35% 85.36%
=======================================
Files 312 312
Lines 7465 7468 +3
Branches 1121 1121
=======================================
+ Hits 6372 6375 +3
Misses 908 908
Partials 185 185
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
- Use environment variables in inline scripts instead of using interpolation to avoid script injection. - Tighten-up some of the default GitHub token permissions.
Fix PowerShell syntax in bash command.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 16 changed files in this pull request and generated no comments.
Files not reviewed (11)
- .github/workflows/actions-lint.yml: Language not supported
- bench/benchmarks.ps1: Language not supported
- build.ps1: Language not supported
- eng/bump-version.ps1: Language not supported
- eng/update-changelog.ps1: Language not supported
- .github/workflows/on-push-do-docs.yml: Evaluated as low risk
- .github/workflows/after-release.yml: Evaluated as low risk
- .github/workflows/dependency-review.yml: Evaluated as low risk
- .github/workflows/nuget-packages-published.yml: Evaluated as low risk
- .github/workflows/update-dotnet-sdk.yml: Evaluated as low risk
- .github/workflows/stale.yml: Evaluated as low risk
Uh oh!
There was an error while loading. Please reload this page.