Skip to content

Conversation

@martincostello
Copy link
Member

@martincostello martincostello commented Feb 15, 2025

  • Add a PowerShell linter.
  • Fix PowerShell lint warnings.
  • Update actionlint to v1.7.7.
  • Use environment variables in inline scripts instead of using interpolation to avoid script injection.
  • Tighten-up some of the default GitHub token permissions.

- Add a PowerShell linter.
- Fix PowerShell lint warnings.
- Update actionlint to v1.7.7.
@martincostello martincostello added enhancement CI/build dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels Feb 15, 2025
- Fix PowerShell lint warnings in workflows.
- Use `${env:}` for consistency.
@codecov
Copy link

codecov bot commented Feb 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.36%. Comparing base (f58fcfb) to head (96cdf7e).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2504   +/-   ##
=======================================
  Coverage   85.35%   85.36%           
=======================================
  Files         312      312           
  Lines        7465     7468    +3     
  Branches     1121     1121           
=======================================
+ Hits         6372     6375    +3     
  Misses        908      908           
  Partials      185      185           
Flag Coverage Δ
linux 85.36% <ø> (+<0.01%) ⬆️
macos 85.36% <ø> (+<0.01%) ⬆️
windows 85.32% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- Use environment variables in inline scripts instead of using interpolation to avoid script injection.
- Tighten-up some of the default GitHub token permissions.
Fix PowerShell syntax in bash command.
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 16 changed files in this pull request and generated no comments.

Files not reviewed (11)
  • .github/workflows/actions-lint.yml: Language not supported
  • bench/benchmarks.ps1: Language not supported
  • build.ps1: Language not supported
  • eng/bump-version.ps1: Language not supported
  • eng/update-changelog.ps1: Language not supported
  • .github/workflows/on-push-do-docs.yml: Evaluated as low risk
  • .github/workflows/after-release.yml: Evaluated as low risk
  • .github/workflows/dependency-review.yml: Evaluated as low risk
  • .github/workflows/nuget-packages-published.yml: Evaluated as low risk
  • .github/workflows/update-dotnet-sdk.yml: Evaluated as low risk
  • .github/workflows/stale.yml: Evaluated as low risk

@martincostello martincostello marked this pull request as ready for review February 15, 2025 15:11
@martincostello martincostello enabled auto-merge (squash) February 15, 2025 15:11
@martincostello martincostello merged commit 32064ed into main Feb 15, 2025
24 checks passed
@martincostello martincostello deleted the powershell-lint branch February 15, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/build dependencies Pull requests that update a dependency file enhancement github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants