Skip to content

Conversation

@martincostello
Copy link
Member

@martincostello martincostello commented Feb 21, 2025

- Add missing coverage identified by #2524.
- Avoid allocating empty delegates.
- Fix-up some formatting.
- Remove redundant code.
@martincostello martincostello added CI/build .NET Pull requests that update .NET code labels Feb 21, 2025
@codecov
Copy link

codecov bot commented Feb 21, 2025

Codecov Report

Attention: Patch coverage is 97.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 96.23%. Comparing base (4083d90) to head (5b47c88).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...cuitBreaker/AdvancedCircuitBreakerTResultSyntax.cs 85.71% 1 Missing ⚠️
...reaker/AsyncAdvancedCircuitBreakerTResultSyntax.cs 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2526      +/-   ##
==========================================
+ Coverage   94.22%   96.23%   +2.00%     
==========================================
  Files         311      311              
  Lines        7413     7327      -86     
  Branches     1038     1013      -25     
==========================================
+ Hits         6985     7051      +66     
+ Misses        335      222     -113     
+ Partials       93       54      -39     
Flag Coverage Δ
linux 96.23% <97.77%> (+2.00%) ⬆️
macos 96.23% <97.77%> (+2.00%) ⬆️
windows 96.22% <97.72%> (+2.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- Add some missing coverage identified in #2525.
- Remove dead code.
- Increase coverage threshold for Polly.Specs.
Fix `SA1129` warning from using default constructor on value type.
Fix inverted values.
Add missing coverage for files changed.
Increase coverage thresholds for Polly.Specs.
@martincostello martincostello marked this pull request as ready for review February 21, 2025 18:57
@martincostello martincostello enabled auto-merge (squash) February 21, 2025 18:58
@martincostello martincostello merged commit 3fb0897 into main Feb 21, 2025
26 checks passed
@martincostello martincostello deleted the kill-mutants branch February 21, 2025 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/build .NET Pull requests that update .NET code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants