Skip to content

Conversation

@martincostello
Copy link
Member

@martincostello martincostello commented Mar 14, 2025

  • Use AuthenticodeLint tool to validate Authenticode signatures again, rather than building and then running a custom fork and branch that works with .NET 8.
  • Revert sign to the same version we used for 8.5.2, as the latest version doesn't seem to be working.

Use AuthenticodeLint tool to validate Authenticode signatures again, rather than building and then runnin a custom fork and branch that works with .NET 8.
@martincostello martincostello added enhancement CI/build .NET Pull requests that update .NET code labels Mar 14, 2025
@codecov
Copy link

codecov bot commented Mar 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.23%. Comparing base (8425fad) to head (488976d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2553   +/-   ##
=======================================
  Coverage   96.23%   96.23%           
=======================================
  Files         311      311           
  Lines        7327     7327           
  Branches     1013     1013           
=======================================
  Hits         7051     7051           
  Misses        222      222           
  Partials       54       54           
Flag Coverage Δ
linux 96.23% <ø> (ø)
macos 96.23% <ø> (ø)
windows 96.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Revert to LKG version used to sign the last release.
Invoke `authlint` not `dotnet authlint`.
Restore conditions now testing complete.
@martincostello martincostello added bug fix dependencies Pull requests that update a dependency file labels Mar 14, 2025
@martincostello martincostello added this to the v8.5.3 milestone Mar 14, 2025
@martincostello martincostello marked this pull request as ready for review March 14, 2025 19:49
@martincostello martincostello enabled auto-merge (squash) March 14, 2025 19:49
@martincostello
Copy link
Member Author

Signing issue is dotnet/sign#827.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug fix CI/build dependencies Pull requests that update a dependency file enhancement .NET Pull requests that update .NET code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants