Skip to content

Conversation

@peter-csala
Copy link
Contributor

@peter-csala peter-csala commented Apr 14, 2025

Pull Request

The issue or feature being addressed

Details on the issue fix or feature implementation

Done

  • Preview
  • Added sample for HttpClient
  • Added sample for Refit
  • Added sample for Flurl
  • Added sample for Restsharp

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@codecov
Copy link

codecov bot commented Apr 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.23%. Comparing base (e15a4a0) to head (5695a95).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2587   +/-   ##
=======================================
  Coverage   96.23%   96.23%           
=======================================
  Files         311      311           
  Lines        7327     7327           
  Branches     1013     1013           
=======================================
  Hits         7051     7051           
  Misses        222      222           
  Partials       54       54           
Flag Coverage Δ
linux 96.23% <ø> (ø)
macos 96.23% <ø> (ø)
windows 96.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@peter-csala peter-csala force-pushed the 2530-Add-http-client-samples branch from 81fe79c to d548d65 Compare April 15, 2025 10:21
@peter-csala peter-csala changed the title [DRAFT] [DOCS] Add HTTP client integration samples [DOCS] Add HTTP client integration samples Apr 15, 2025
@peter-csala peter-csala marked this pull request as ready for review April 15, 2025 10:47
@peter-csala
Copy link
Contributor Author

@martincostello Could you please review it?

Copy link
Member

@martincostello martincostello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs vNext adding to .github/wordlist.txt.

@peter-csala
Copy link
Contributor Author

Just needs vNext adding to .github/wordlist.txt.

Thank you for the review and the suggestions.

@martincostello martincostello enabled auto-merge (squash) April 17, 2025 13:36
@martincostello martincostello merged commit 2988010 into App-vNext:main Apr 17, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants