-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Pass timeout to TimeoutRejectedException #2827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pass the value of `timeout` to `TimeoutRejectedException` in Polly for timeout policies. Resolves #2815.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR enhances the TimeoutRejectedException by passing the timeout value that caused the exception, making it easier for consumers to understand and handle timeout scenarios.
- Timeout parameter is now passed to
TimeoutRejectedExceptionin both synchronous and asynchronous timeout engines - Tests updated to verify the timeout value is correctly set in the exception
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Polly/Timeout/TimeoutEngine.cs | Updated to pass timeout parameter when throwing TimeoutRejectedException |
| src/Polly/Timeout/AsyncTimeoutEngine.cs | Updated to pass timeout parameter when throwing TimeoutRejectedException in async scenarios |
| test/Polly.Specs/Timeout/TimeoutSpecs.cs | Added test assertion to verify timeout value is set correctly in pessimistic strategy |
| test/Polly.Specs/Timeout/TimeoutAsyncSpecs.cs | Added test assertion to verify timeout value is set correctly in async pessimistic strategy |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2827 +/- ##
=======================================
Coverage 96.15% 96.15%
=======================================
Files 309 309
Lines 7123 7123
Branches 1005 1005
=======================================
Hits 6849 6849
Misses 221 221
Partials 53 53
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Pass the value of
timeouttoTimeoutRejectedExceptioninPollyfor timeout policies.Resolves #2815.