Skip to content
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
a506f02
Add core RateLimiter implementations
reisenberger Mar 23, 2019
e31aa32
Add example async TResult rate-limiter policy implementation
reisenberger Mar 23, 2019
12a276a
Add example syntax
reisenberger Mar 23, 2019
6e2da28
Make the retryAfterFactory take Timespan as an input parameter!
reisenberger Mar 24, 2019
f5435e4
Initial LockFreeTokenBucketRateLimiterTests
reisenberger Jul 4, 2019
adbefab
Factor out test helpers
reisenberger Jul 4, 2019
29a63fa
Factor out common tests; add tests on lock-based rate limiter
reisenberger Jul 4, 2019
6ff0448
Allow for slow-running on CI servers
reisenberger Jul 4, 2019
ead0d14
Add tests on full bucket capacity
reisenberger Jul 4, 2019
ce36ab2
Fix RateLimitRejectedException
reisenberger Jul 4, 2019
9b74ae1
Remove unused configuration overloads
reisenberger Jul 4, 2019
0e0d94f
Introduce a factory for obtaining the preferred rate-limiter implemen…
reisenberger Jul 4, 2019
3d83844
Pull some test helper methods into a common base-class
reisenberger Jul 4, 2019
23f26e8
Add first specs on async policy syntax
reisenberger Jul 4, 2019
d0f191b
Add full set of specs on rate-limit policies thus far
reisenberger Jul 5, 2019
705cda9
Add tests on retryAfterFactory
reisenberger Jul 5, 2019
68346c7
Add tests on context passed to retryAfterFactory
reisenberger Jul 5, 2019
1895edc
Add async non-generic syntax and specs
reisenberger Jul 5, 2019
dd10d3e
Improve code layout
reisenberger Jul 5, 2019
a734da2
Add sync rate-limit policies
reisenberger Jul 5, 2019
ba96aac
Add initial rate-limit doco; bump to v7.3.0
reisenberger Jul 9, 2019
f237d8f
Improve bulkhead doco in readme
reisenberger Jul 9, 2019
b41cac4
Minor expressivity refinements
reisenberger Jul 15, 2019
1370cdb
Neaten bulkhead tests commentary
reisenberger Jul 16, 2019
b890f01
Control visibility of IRateLimiter components
reisenberger Jul 16, 2019
f232595
Fix non-generic rate-limit tests to be genuinely non-generic
reisenberger Jul 16, 2019
e566ea9
Fix ShouldThrow syntax errors in specs
YarekTyshchenko Oct 15, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Minor expressivity refinements
  • Loading branch information
reisenberger authored and YarekTyshchenko committed Oct 15, 2021
commit b41cac4016df3fd6e152cc9db412a73da98181d4
9 changes: 6 additions & 3 deletions src/Polly/RateLimit/LockBasedTokenBucketRateLimiter.cs
Original file line number Diff line number Diff line change
Expand Up @@ -65,11 +65,14 @@ public LockBasedTokenBucketRateLimiter(TimeSpan onePer, long bucketCapacity)
// Time to add tokens to the bucket!

// We definitely need to add one token. In fact, if we haven't hit this bit of code for a while, we might be due to add a bunch of tokens.
long tokensMissedAdding = -ticksTillAddNextToken / addTokenTickInterval;
// For clarity: it's time to add 1 + tokensMissedAdding tokens to the bucket.
long tokensMissedAdding =
// Passing addNextTokenAtTicks merits one token
1 +
// And any whole token tick intervals further each merit another.
(-ticksTillAddNextToken / addTokenTickInterval);

// We mustn't exceed bucket capacity though.
long tokensToAdd = Math.Min(bucketCapacity, 1 + tokensMissedAdding);
long tokensToAdd = Math.Min(bucketCapacity, tokensMissedAdding);

// Work out when tokens would next be due to be added, if we add these tokens.
long newAddNextTokenAtTicks = addNextTokenAtTicks + tokensToAdd * addTokenTickInterval;
Expand Down
9 changes: 6 additions & 3 deletions src/Polly/RateLimit/LockFreeTokenBucketRateLimiter.cs
Original file line number Diff line number Diff line change
Expand Up @@ -69,11 +69,14 @@ public LockFreeTokenBucketRateLimiter(TimeSpan onePer, long bucketCapacity)
// Time to add tokens to the bucket!

// We definitely need to add one token. In fact, if we haven't hit this bit of code for a while, we might be due to add a bunch of tokens.
long tokensMissedAdding = -ticksTillAddNextToken / addTokenTickInterval;
// For clarity: it's time to add 1 + tokensMissedAdding tokens to the bucket.
long tokensMissedAdding =
// Passing addNextTokenAtTicks merits one token
1 +
// And any whole token tick intervals further each merit another.
(-ticksTillAddNextToken / addTokenTickInterval);

// We mustn't exceed bucket capacity though.
long tokensToAdd = Math.Min(bucketCapacity, 1 + tokensMissedAdding);
long tokensToAdd = Math.Min(bucketCapacity, tokensMissedAdding);

// Work out when tokens would next be due to be added, if we add these tokens.
long newAddNextTokenAtTicks = currentAddNextTokenAtTicks + tokensToAdd * addTokenTickInterval;
Expand Down