Skip to content

Conversation

@vivekkothakota
Copy link

@vivekkothakota vivekkothakota commented Jul 24, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

ragargms and others added 30 commits May 30, 2018 12:05
* Add specs for machine learning services provider

* Added python config to readme

* Added repo generation for Python

* Addressed feedback

* Address more comments
* Adding new value to VA baseline name

Adding new value to VA baseline name

* Fix typo

Fix typo

* Updating VulnerabilityAssessmentPolicyBaselineName

* Fixed all comments
* Add specs for Microsoft.IoTCentral RP

Merge from private repo. PR: Azure/azure-rest-api-specs-pr#472

* Fix support for ruby sdk

Change package_name to align with iothub
* Add custom VNET model definition.

* [AKS] add new 2018-03-31 API

* Add regex validations and x-ms-enum defs for VNET params

* Add IP address regex and defaults for CIDR fields

* Add addonProfile

* Add enableRBAC boolean to ManagedClusterProperties

* Add AADProfile to ManagedClusterProperties

* Add ARM operations API

* Rename an example file to start with a capital letter

* Reconcile two definitions of OSType enum.

* Rename to ManagedClusterAgentPoolProfile.

Its fields have diverged from ContainerServiceAgentPoolProfile.

* Py version

* Revert "Reconcile two definitions of OSType enum."

This reverts commit 2104f85.

* Reconcile two definitions of OSType enum.

Added "modelAsString" to containerServices' definition.

* Incorporated review comments

* Fixed examples errors pointed out by oav tool
…er fixes. (#3152)

* Fix List VM Extension API name, description updates and fix for 2018-06-01 version

* Add VMSS Ip Tag
* Adding CSharp readme for multiApi support

* updating the config to retain previously set defaults

* Updating Authorization, Resource manager multi api tags for Azure Stack

* Fixing to the correct tag name

* adjusting casing for multiapi switch. Adding defualt config setting for CSharp generation. Adding tags for Resoruce Manager azure stack multiapi generation.
* fix ocr language parameter to fix [bug](Azure/azure-sdk-for-net#4083)
* language parameter missing for /tag path
* language parameter missing for /models/*/analyze path
* make /models/*/analyze return a more generic type
* add specific types for /models/*/analyze to return for current models
…ile (#2895)

* API profile map for the profile version 2017-03-09-profile

* added 2018-03-01-hybrid profile json

* Addressed the review comments

* Adding supported resource types explicitly

* Microsoft.Web resource types and fixing resources apiversion

* Fixing Microsoft.Web, Fixing Locks resource type and updating readme for the changes

* Removing the providerOperations under Auth and pricingTiers,quotasettings under Web, picking up available swagger versions for /subscriptions
* Added GA API version for Scheduled Query Rule

Added GA API version for Scheduled Query Rule

* Resolving Comments

Resolving Comments

* Made SKU as top level proprty and including generic error response format

Couple of changes -
1. Made SKU as top level proprty as mentioned here - https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/resource-api-reference.md#put-resource
 2. including generic error response format

* Minor Changes to align implementation

1. Removed SKU - Billing Model is still under discussion, hence need not to be exposed to customers.
2.  Enabled field ichanged to align with camel case.
3.  'throttleTillDate' in properties.action changed to 'throttlingInMin' to denote correct meaning  and it’s data type changed to number instead of date.
4. 'status' to be removed in properties.action from examples.
5.  'severity' made a required field in properties.action.
6. Removed Examples from original spec json

* Updated Example to reflect AI instances in tags and 'dataSourceId"

Updated Example to reflect AI instances in tags and 'dataSourceId"

* made 'tags' details more descriptive

* Restore Tags Description

Restore Tags Description

* Fixed Exmaple Validation

Fixed errores reported by running command "oav validate-example"

* Added Default Response payload in all APIs

Changes -
1. Added Default Response payload in all APIs
2. Made azNs description more clear

* Updating descriptions + property name change

Updating descriptions + property name change

* Patch Support for SQR API

* Updated description for queryType

Updated description for queryType

* Update scheduledQueryRule_API.json

* Resolving multiple model issue

Changes - 
1. Renamed "MetricTrigger" to "LogMetricTrigger"
2. Aligned "Resources" to other specs
* reset.

* update.

* Update readme.md.

* update readme.md.

* fix.

* add changes for readme.csharp.md.
…w api version (#3154)

* Create a new folder and add old api version files to the folder

* Remove uidefinitionuri from managed app properties in responces

* Added new api version for managed applications to readme files.

* add  new api version for managed apps for python

* fix semantic validation errors
* copying all changes from private repo for 2018-06-01

* Update readme.md

* renaming autoFit to instanceFlexibility and its enum values

* fix all example responses with autoFit rename to instanceFlexibility

* moved 2018-11-01 from stable to preview

* editing from stable to preview for 2018-06-01 in readme.md
* Adding June API

* updating api version

* updating basic information to point at correct tag

* updating api version in the examples

* updating GO tags in README
* Update openapi-authoring-automated-guidelines.md

* Update openapi-authoring-automated-guidelines.md

* Update openapi-authoring-automated-guidelines.md

* Update openapi-authoring-automated-guidelines.md

* Update openapi-authoring-automated-guidelines.md

* Update openapi-authoring-automated-guidelines.md

* Update openapi-authoring-automated-guidelines.md
* Add schema mapping for hierarchical data

* Add example for column mapping
…rmat object of networkInterface.json definition of Network 2015-06-15 spec (#3200)
* One file for server and db apis

Make one file which is blobAuditing.json that contains both server & db apis + update readme.md and add operations.json

* Add extended server auditing settings API

* Fixed operation id.

* Enable Database Auditing Filtiring With a Predicate Expression

New API which enables database auditing filtering by a where clause.

* Enable Database Auditing Filtiring With a Predicate Expression

New API which enables database auditing filtering by a where clause.
In addition, existing related APIs swaggers were unified under same Public API name.

* Enable Database Auditing Filtiring With a Predicate Expression

New API which enables database auditing filtering by a where clause.
In addition, existing related APIs swaggers were unified under same Public API name.

* Fixing examples of existing APIs and modifying blobAuditing Swagger file

storageAccountAccessKey was removed from requests response, and examples were modified accordingly.

* Remove description of predicateExpression related exceptions from old APIs description.

Fixing a small issue for client readability.
AuditingSettings and ExtendedAuditingSettings APIs have a mutual exceptions description. Description which mentions predicateExpression parameter in all APIs.
After this fix, predicateExpression related exceptions will not be mentioned on old APIs.

* Moving files to preview/stable as appropriate.

* Modifying swagger and examples of 2017 BlobAuditing APIs (#421)

* 2017 Blob Auditing APIs - Swagger and examples.

Modifying swagger and examples of 2017 blob auditing APIs.

* Resetting examples of DatabaseBlobAuditing API to 2017

Resetting examples of DatabaseBlobAuditing API to 2017

* Fixing follwing comments

Fixing follwing comments

* Fixing build errors

Fixing build errors

* Fix build errors

Fix build errors

* Fixing comments

fixing comments

* Removed 2017 database API

Removed 2017 database API

* Revert "Fixing comments"

This reverts commit c09f9f6.

* Modifying description of APIs

Modifying description of APIs after generating new swagger.

* Modifying readme.md.

Modifying readme.md.

* Updating blobAuditing Json files.

Updating blobAuditing Json files.

* Temp change

Temp change

* Final commit

Final commit

* Fix Duplicated model name with non-identical definitions build error

Fix Duplicated model name with non-identical definitions

* Fix Duplicated model name with non-identical definitions build error

This reverts commit 616851d and commits fixes.

* Fix Automation Duplicated model name with non-identical definitions

Fix Automation Duplicated model name with non-identical definitions

* One file for server and db apis

Make one file which is blobAuditing.json that contains both server & db apis + update readme.md and add operations.json

* Add extended server auditing settings API

* Fixed operation id.

* Enable Database Auditing Filtiring With a Predicate Expression

New API which enables database auditing filtering by a where clause.

* Enable Database Auditing Filtiring With a Predicate Expression

New API which enables database auditing filtering by a where clause.
In addition, existing related APIs swaggers were unified under same Public API name.

* Enable Database Auditing Filtiring With a Predicate Expression

New API which enables database auditing filtering by a where clause.
In addition, existing related APIs swaggers were unified under same Public API name.

* Fixing examples of existing APIs and modifying blobAuditing Swagger file

storageAccountAccessKey was removed from requests response, and examples were modified accordingly.

* Remove description of predicateExpression related exceptions from old APIs description.

Fixing a small issue for client readability.
AuditingSettings and ExtendedAuditingSettings APIs have a mutual exceptions description. Description which mentions predicateExpression parameter in all APIs.
After this fix, predicateExpression related exceptions will not be mentioned on old APIs.

* Moving files to preview/stable as appropriate.

* Modifying swagger and examples of 2017 BlobAuditing APIs (#421)

* 2017 Blob Auditing APIs - Swagger and examples.

Modifying swagger and examples of 2017 blob auditing APIs.

* Resetting examples of DatabaseBlobAuditing API to 2017

Resetting examples of DatabaseBlobAuditing API to 2017

* Fixing follwing comments

Fixing follwing comments

* Fixing build errors

Fixing build errors

* Fixing comments

fixing comments

* Removed 2017 database API

Removed 2017 database API

* Revert "Fixing comments"

This reverts commit c09f9f6.

* Modifying description of APIs

Modifying description of APIs after generating new swagger.

* Modifying readme.md.

Modifying readme.md.

* Updating blobAuditing Json files.

Updating blobAuditing Json files.

* Temp change

Temp change

* Final commit

Final commit

* Fix Python conf of servermanager (#3140)

* Fix ServerManager Py Conf (#3141)

* Plug SwaggerToSdk to LogAnalyticsMgmt (#3142)

* [Storage] Support Management policy on new api version 2018-03-01-preview (#3137)

* [Storage] Add new API version 2018-03-01-preview

* [Storage] Update rest version 2018-03-01-preview

* [Storage] Support Management Policy

* [Storage] Update since code review comments

* Add Python conf

* [Storage] Add managment policy doc link to policy description.

* [Storage] modify as review comments

* RSA key size examples, ECC descriptions (#3136)

* RSA key size examples, ECC descriptions

* remove preview changes for now

* Added GroupType property in HybridWorkerGroup (#3132)

* Watcher resource swagger specs. For more details on the Usage of the resource: https://docs.microsoft.com/en-us/azure/automation/automation-watchers-tutorial (#3102)

* Watcher specs

* using the same model for get/put input and output.

* Fix storage Python conf (#3148)

* Fix for Azure Networking swagger 2018-04-01 version (#3146)

* Adding swagger for new api-version consumption 2018-05-31, introducing new Forecast api swagger (#3114)

* Forecast Api swagger

* consumption readme file update for the new swagger version

* addressing review comment on adding nextLink

* fixing build error

* Addressed feedback on enum and fixed a typo

* Stop using unobscured credentials

* Fix Duplicated model name with non-identical definitions build error

Fix Duplicated model name with non-identical definitions

* Fix go tag for storage management plane 2018-03-02 api version (#3156)

* Refactoring Job Definitions (#3116)

* MySQL/PostgreSQL VNET with API Version 2017-12-01 for Public Preview. (#3138)

* Fix Python conf

* Adding the VNET Rest APIs to 2017-12-01 version.

Adding the VNET Rest APIs to 2017-12-01 version.

* Add specs for machine learning services provider (#3135)

* Add specs for machine learning services provider

* Added python config to readme

* Added repo generation for Python

* Addressed feedback

* Address more comments

* Adding Security RP API swagger (#3144)

* Reverted methods in vpn gateways. (#3163)

* Fix Duplicated model name with non-identical definitions build error

This reverts commit 616851d and commits fixes.

* Fix Automation Duplicated model name with non-identical definitions

Fix Automation Duplicated model name with non-identical definitions

* Revert "Fix Duplicated model name with non-identical definitions build error"

This reverts commit d1c40f7.

* Revert "Fix Duplicated model name with non-identical definitions build error"

This reverts commit 2c1261e.

* Update readme.md file

Update readme.md file
* [AKS] add nodeResourceGroup property

* Increment python package version to 4.1.0

* Update example JSON with nodeResourceGroup
* add bing autosuggest spec

* rename generated folder

* update spec

* update spec

* update spec

* add name in SuggestionGroup

* refer the example in spec file

* update sepc

* update spec

* suppress -type error

* suppress R3016 error

* update spec

* update spec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.