Skip to content

Conversation

@ashutoshvarma
Copy link
Contributor

@ashutoshvarma ashutoshvarma commented Jul 5, 2024

Important Changes

XCM

Runtime

(still updating the summary..., meanwhile please check the notion page)

TODO

  • debug the test_async_xcm_contract_call_no_ce xcm simulator test, ignored for now
  • figure out dapp staking valid default config (construct_runtime! added test to build the default config now)
  • enable & test PoV reclaim (or not enable?)
  • move migrations from Executive to frame_system's SingleBlockMigration config (not on this PR, maybe later)
  • test XCMv4 compatibility
  • test migrations
  • run benchmarks
  • fix evm tracing

@Dinonard
Copy link
Contributor

They're features added by this uplift, either we use them or not is another discussion I guess. There are enough changes for this PR

Completely agree, let's just convert them into issues/future items so we don't forget.

@ermalkaleci
Copy link
Contributor

/bench astar-dev,shibuya-dev,shiden-dev orml_oracle

@ermalkaleci
Copy link
Contributor

/bench astar-dev,shibuya-dev,shiden-dev orml_oracle

@github-actions
Copy link

Benchmarks job is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/9897807613.
Please wait for a while.
Branch: feat/uplift-v1.9.0
SHA: 69a30f2

@github-actions
Copy link

Benchmarks have been finished.
You can download artifacts if exists https://github.com/AstarNetwork/Astar/actions/runs/9897807613.

Copy link
Contributor

@Dinonard Dinonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please just revert the author/repo changes in the vendor toml file.

Comment on lines +1156 to +1172
/// OracleMembership wrapper used by benchmarks
#[cfg(feature = "runtime-benchmarks")]
pub struct OracleMembershipWrapper;

#[cfg(feature = "runtime-benchmarks")]
impl frame_support::traits::SortedMembers<AccountId> for OracleMembershipWrapper {
fn sorted_members() -> Vec<AccountId> {
OracleMembership::sorted_members()
}

fn add(account: &AccountId) {
frame_support::assert_ok!(OracleMembership::add_member(
frame_system::RawOrigin::Root.into(),
account.to_owned().into()
));
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be extracted into primitives?

[package]
name = "evm-tracing-events"
authors = ["PureStake"]
authors = { workspace = true }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please just revert the authors & repository changes.

Dinonard
Dinonard previously approved these changes Jul 12, 2024
Copy link
Contributor

@Dinonard Dinonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏 💪

@ermalkaleci
Copy link
Contributor

ermalkaleci commented Jul 12, 2024

/runtime-upgrade-test shibuya

@github-actions
Copy link

Invalid runtime. It should be 'shibuya', 'shiden', or 'astar'.

@github-actions
Copy link

Runtime upgrade test is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/9906066347.
Please wait for a while.
Runtime: shibuya
Branch: feat/uplift-v1.9.0
SHA: 095b91c

@ermalkaleci
Copy link
Contributor

/runtime-upgrade-test shiden

@ermalkaleci
Copy link
Contributor

/runtime-upgrade-test astar

@github-actions
Copy link

Runtime upgrade test is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/9906099998.
Please wait for a while.
Runtime: shiden
Branch: feat/uplift-v1.9.0
SHA: 095b91c

@github-actions
Copy link

Runtime upgrade test is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/9906101453.
Please wait for a while.
Runtime: astar
Branch: feat/uplift-v1.9.0
SHA: 095b91c

@ermalkaleci ermalkaleci mentioned this pull request Jul 12, 2024
Base automatically changed from uplift-sdk-v1.5 to master July 12, 2024 10:10
@ermalkaleci ermalkaleci dismissed Dinonard’s stale review July 12, 2024 10:10

The base branch was changed.

@ermalkaleci ermalkaleci merged commit 31763c5 into master Jul 12, 2024
@ermalkaleci ermalkaleci deleted the feat/uplift-v1.9.0 branch July 12, 2024 10:19
@github-actions
Copy link

Code Coverage

Package Line Rate Branch Rate Health
pallets/inflation/src 86% 0%
chain-extensions/types/xvm/src 0% 0%
precompiles/xcm/src 71% 0%
pallets/xvm/src 54% 0%
precompiles/sr25519/src 64% 0%
pallets/astar-xcm-benchmarks/src/fungible 100% 0%
chain-extensions/types/assets/src 0% 0%
chain-extensions/unified-accounts/src 0% 0%
precompiles/assets-erc20/src 78% 0%
pallets/collective-proxy/src 86% 0%
pallets/static-price-provider/src 52% 0%
primitives/src 62% 0%
pallets/dapp-staking-v3/src 90% 0%
precompiles/dispatch-lockdrop/src 86% 0%
pallets/price-aggregator/src 75% 0%
chain-extensions/xvm/src 0% 0%
pallets/dapp-staking-migration/src 0% 0%
pallets/unified-accounts/src 77% 0%
pallets/dapp-staking-v3/src/test 0% 0%
precompiles/unified-accounts/src 100% 0%
primitives/src/xcm 65% 0%
precompiles/xvm/src 73% 0%
pallets/dapp-staking-v3/src/benchmarking 98% 0%
chain-extensions/pallet-assets/src 56% 0%
pallets/ethereum-checked/src 79% 0%
pallets/dynamic-evm-base-fee/src 89% 0%
pallets/astar-xcm-benchmarks/src/generic 100% 0%
chain-extensions/types/unified-accounts/src 0% 0%
pallets/xc-asset-config/src 50% 0%
precompiles/dapp-staking-v3/src/test 0% 0%
pallets/collator-selection/src 92% 0%
precompiles/substrate-ecdsa/src 74% 0%
precompiles/dapp-staking-v3/src 90% 0%
pallets/dapp-staking-v3/rpc/runtime-api/src 0% 0%
pallets/astar-xcm-benchmarks/src 86% 0%
Summary 76% (3706 / 4850) 0% (0 / 0)

Minimum allowed line rate is 50%

@ermalkaleci ermalkaleci mentioned this pull request Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

astar Related to Astar runtime This PR/Issue is related to the topic “runtime”. shibuya related to shibuya shiden related to shiden runtime

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants