com.ning.http.client.providers.netty.NettyAsyncHttpProvider imposes hard limit of HttpHeader size

[tejalk]

com.ning.http.client.providers.netty.NettyAsyncHttpProvider imposes hard limit of HttpHeader size. The NettyAsyncHttpProvider adds HttpClientCodec to the pipeline which imposes a MaxHeaderSize of 8192.

This should be configurable.

[bric3]

same as GrizzlyAsyncHttpProvider by the way

[slandelle]

8ko is a classic value, as servers do have limitations (httpd and nginx limits are 8ko).

Is this a real issue or just an opinion?

[bric3]

Yes real issue for me, actually we are using AHC with a legacy server, that transmit a great deal of informations through headers. And there could be quite a lot. If this limit is not configurable we have no choice but either patch AHC or use something else.

[slandelle]

I will kind of backport this on 1.7.x so you get the feature in 1.7.12.
@rlubke Do you want to implement this for the Grizzly provider?

[slandelle]

Actually, this feature already exists in 1.7.x but did not in master?!
@bric3 see https://github.com/AsyncHttpClient/async-http-client/blob/ahc-1.7.x/src/main/java/com/ning/http/client/providers/netty/NettyAsyncHttpProvider.java#L309

@jfarcand One can have different settings for HTTP and HTTPS. That looks overkill to me. Do you want me to keep what I've done in master, or do you prefer the 1.7.x way with separate settings?

[bric3]

I don't remember precisely the context as it dates a few months back, but I remember a few pull request we've done to enable such a configuration. But I didn't want this feature to be removed.

[slandelle]

I won't have time tracking what happened, but the master and 1.7.x branches have been living apart for quite long (too long actually). It seems that the pull request was done against 1.7.x and was not ported on master.

[bric3]

Fair enough. Will this be ported on master then ?

[slandelle]

Seems you missed some comments. Please read the whole thread.

[bric3]

OK. Thanks I missed the commit.

[rlubke]

Re-opening to keep on my radar.

[jfarcand]

@slandelle +1 to use what you did on master.