Do not use System.currentTimeMillis()

[ash2k]

When measuring intervals of time it's much better & safer to use System.nanoTime() than System.currentTimeMillis(). The latter is affected by system clock drift and adjustments (like by system time daemon) and the former is much more precise and stable.
For example NettyResponseFuture can be improved and maybe some other classes.

[slandelle]

👍

[jfarcand]

IIRC, does JDK 5 supports System.nanoTime() (I'm lazy)? That may explain why I used it at the first place.

[slandelle]

Yep, it does:
http://docs.oracle.com/javase/1.5.0/docs/api/java/lang/System.html#nanoTime()

2013/4/19 Jeanfrancois Arcand notifications@github.com

IIRC, does JDK 5 supports System.nanoTime() (I'm lazy)? That may explain
why I used it at the first place.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/280#issuecomment-16655622
.

[slandelle]

Woups, forgot that nanoTime value is OS dependent and should only be used for measuring differences. I have to partially rollback.