Skip to content

Support for OpenSslEngine with no finalizer #1695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Support for OpenSslEngine with no finalizer #1695

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Support for OpenSslEngine with no finalizer 
Motivation:

Custom SslContext should be retained on init.

Modification:

Retain custom SslContext.

Result:

Externally managed SslContext refcount is managed correctly.
  • Loading branch information
@johnou
johnou committed Feb 5, 2020
commit 22502d7769e28d5a75a9351c1d2a4c86a1f808bd
1 change: 1 addition & 0 deletions client/src/main/java/org/asynchttpclient/netty/ssl/DefaultSslEngineFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ public class DefaultSslEngineFactory extends SslEngineFactoryBase {

private SslContext buildSslContext(AsyncHttpClientConfig config) throws SSLException {
if (config.getSslContext() != null) {
ReferenceCountUtil.retain(config.getSslContext());
return config.getSslContext();
}

Expand Down