close channel on request timeout #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abort sets channel to null without closing it, which causes NPE on getPipeline, which results in FutureTask ressetting without channel ever being closed.
Contributor
|
Good catch! Thanks! |
oleksiys
pushed a commit
that referenced
this pull request
Jul 15, 2014
#525 "Move the hostname verification to after the SSL handshake has completed"
cs-workco
pushed a commit
to cs-workco/async-http-client
that referenced
this pull request
Apr 13, 2023
Update readme with simple tutorial
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
abort sets channel to null (but does not close channel), yielding NPE on channel.getPipeline, which is caught in FutureTask.innerRunAndReset ==> future is canceled, but markChannelNotReadable never executed & channel never closed.