Merge pull request swimlane#1229 from ivankolev/master

amcdnl · web-flow · commit 0098a48e7150 · 2018-01-21T13:05:22.000-06:00
swimlane#880, make the demo at /#virtual-paging work properly
diff --git a/src/components/body/body.component.ts b/src/components/body/body.component.ts
@@ -207,7 +207,7 @@ export class DataTableBodyComponent implements OnInit, OnDestroy {
    * calculate scroll height automatically (as height will be undefined).
    */
   get scrollHeight(): number | undefined {
-    if (this.scrollbarV) {
+    if (this.scrollbarV && this.rowCount) {
       return this.rowHeightsCache.query(this.rowCount - 1);
     }
     // avoid TS7030: Not all code paths return a value.

Original file line number	Diff line number	Diff line change
`@@ -207,7 +207,7 @@ export class DataTableBodyComponent implements OnInit, OnDestroy {`
`207`	`207`	`* calculate scroll height automatically (as height will be undefined).`
`208`	`208`	`*/`
`209`	`209`	`get scrollHeight(): number \| undefined {`
`210`		`- if (this.scrollbarV) {`
	`210`	`+ if (this.scrollbarV && this.rowCount) {`
`211`	`211`	`return this.rowHeightsCache.query(this.rowCount - 1);`
`212`	`212`	`}`
`213`	`213`	`// avoid TS7030: Not all code paths return a value.`