#880, make the demo at /#virtual-paging work properly #1229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t index -1 failed: Fenwick tree array not initialized.' and make the demo work properly at https://swimlane.github.io/ngx-datatable/#virtual-paging
amcdnl
reviewed
Jan 11, 2018
| @Input() set rows(val: any[]) { | ||
| this._rows = val; | ||
| this.rowExpansions.clear(); | ||
| this._rowCount = this._rows.length; |
Contributor
There was a problem hiding this comment.
This won't work right since the row count varies. There is a function to get this information.
Contributor
Author
There was a problem hiding this comment.
Aah, I see that /#server-paging is indeed broken with my change. Wonder if it's worth it to maybe add more e2e tests that could potentially catch such errors.
Contributor
Author
|
Ok, back to the drawing board then. It fixes the error and all the tests passed, so I assumed it was enough. So, just to make it clear, there could be cases where rowCount is not equal to the number of rows? |
Contributor
|
Server side paging. |
Contributor
Author
|
Alright, I have pushed my second attempt at it, both /#server-paging and /#virtual-paging seem to be working now... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set rowCount to rows.length, to prevent 'Error: query at index -1 failed: Fenwick tree array not initialized.' and make the demo work properly at https://swimlane.github.io/ngx-datatable/#virtual-paging
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
As described in the issue #880 and currently on https://swimlane.github.io/ngx-datatable/#virtual-paging or http://localhost:9999/#virtual-paging, virtual paging demo throws an error because the rowCount does not properly reflect the number of rows
What is the new behavior?
Fixes the said javascript error and make the demo work as intended
Does this PR introduce a breaking change? (check one with "x")