Fixing ArmNavigation/rrt_star_seven_joint_arm_control/rrt_star_seven_joint_arm_control.py #1022
Conversation
| def draw_graph(self, rnd=None): | ||
| plt.cla() | ||
| self.ax.axis([-1, 1, -1, 1]) | ||
| self.ax.axis([-1, 1, -1, 1, -1, 1]) |
There was a problem hiding this comment.
This is the main fix
| print("Cannot find path") | ||
| else: | ||
| print("found path!!") | ||
| plt.ion() |
There was a problem hiding this comment.
Adding a loop so the user can rewatch the animation
| [y for y in y_points], | ||
| [z for z in z_points], | ||
| "o-", color="grey", ms=4, mew=0.5) | ||
| plt.pause(0.1) |
There was a problem hiding this comment.
increasing the pause time, because it seems way to fast
There was a problem hiding this comment.
Increasing the pause time makes sense for me, but what is for other changes?
There was a problem hiding this comment.
@timmarkhuff Thank you for your PR. Could you please fix the CI failures?
| [y for y in y_points], | ||
| [z for z in z_points], | ||
| "o-", color="grey", ms=4, mew=0.5) | ||
| plt.pause(0.1) |
There was a problem hiding this comment.
Increasing the pause time makes sense for me, but what is for other changes?
Sorry didn't realize they had failed. Should be good now. I was trying to allow the user to replay the animation. The idea is they could reposition the camera, hit a button and the animation would replay. It wasn't working quite the way I wanted, and it was causing a CI failure that I could not fix, so I just removed it. |
|
@timmarkhuff Thank you!! |
2 participants
When I run
ArmNavigation/rrt_star_seven_joint_arm_control/rrt_star_seven_joint_arm_control.py, I get an error:Reference issue
#1021
What does this implement/fix?
I changed
self.ax.axis([-1, 1, -1, 1])toself.ax.axis([-1, 1, -1, 1, -1,]) as the error message suggests.Additionally, the animation plays way too fast in my opinion, so I increased the pause time.
CheckList