Skip to content

Conversation

goktug97
Copy link
Contributor

After adding the rectangle obstacle calculation, I've tested the algorithm more to try different settings
and I've seen that sometimes robot hits obstacles, specifically during turns. I've realized, the yaw angle should be positive instead of negative while rotating the obstacles because of the dot order (a @ rot instead of rot @ a). After the change, the robot stops before hitting the obstacles.

@goktug97 goktug97 changed the title Fix wrong rotation direction DWA Fix wrong rotation direction Oct 26, 2019
- The obstacle rotation for the rectangle obstacle calculation
is wrong. It should be positive instead of negative.
@coveralls
Copy link

coveralls commented Oct 27, 2019

Pull Request Test Coverage Report for Build 1063

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 14 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.1%) to 90.22%

Files with Coverage Reduction New Missed Lines %
PathPlanning/ClosedLoopRRTStar/pure_pursuit.py 4 92.25%
PathPlanning/ReedsSheppPath/reeds_shepp_path_planning.py 10 88.19%
Totals Coverage Status
Change from base Build 1051: -0.1%
Covered Lines: 6725
Relevant Lines: 7454

💛 - Coveralls

@AtsushiSakai AtsushiSakai merged commit a737062 into AtsushiSakai:master Oct 27, 2019
@AtsushiSakai
Copy link
Owner

@goktug97 Good catch!!.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants