-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
Spiral Spanning Tree Coverage Path Planning #355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull Request Test Coverage Report for Build 1507
💛 - Coveralls |
Thank you again!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some comments. PTAL
PathPlanning/SpiralSpanningTreeCPP/spiral_spanning_tree_coverage_path_planner.py
Outdated
Show resolved
Hide resolved
PathPlanning/SpiralSpanningTreeCPP/spiral_spanning_tree_coverage_path_planner.py
Outdated
Show resolved
Hide resolved
PathPlanning/SpiralSpanningTreeCPP/spiral_spanning_tree_coverage_path_planner.py
Outdated
Show resolved
Hide resolved
PathPlanning/SpiralSpanningTreeCPP/spiral_spanning_tree_coverage_path_planner.py
Outdated
Show resolved
Hide resolved
PathPlanning/SpiralSpanningTreeCPP/spiral_spanning_tree_coverage_path_planner.py
Outdated
Show resolved
Hide resolved
PathPlanning/SpiralSpanningTreeCPP/spiral_spanning_tree_coverage_path_planner.py
Outdated
Show resolved
Hide resolved
PathPlanning/SpiralSpanningTreeCPP/spiral_spanning_tree_coverage_path_planner.py
Outdated
Show resolved
Hide resolved
PathPlanning/SpiralSpanningTreeCPP/spiral_spanning_tree_coverage_path_planner.py
Outdated
Show resolved
Hide resolved
PathPlanning/SpiralSpanningTreeCPP/spiral_spanning_tree_coverage_path_planner.py
Outdated
Show resolved
Hide resolved
PathPlanning/SpiralSpanningTreeCPP/spiral_spanning_tree_coverage_path_planner.py
Outdated
Show resolved
Hide resolved
PathPlanning/SpiralSpanningTreeCPP/spiral_spanning_tree_coverage_path_planner.py
Outdated
Show resolved
Hide resolved
PathPlanning/SpiralSpanningTreeCPP/spiral_spanning_tree_coverage_path_planner.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for updating code. This is the last review. I will merge it after addressing my comments.
PathPlanning/SpiralSpanningTreeCPP/spiral_spanning_tree_coverage_path_planner.py
Outdated
Show resolved
Hide resolved
PathPlanning/SpiralSpanningTreeCPP/spiral_spanning_tree_coverage_path_planner.py
Outdated
Show resolved
Hide resolved
PathPlanning/SpiralSpanningTreeCPP/spiral_spanning_tree_coverage_path_planner.py
Show resolved
Hide resolved
PathPlanning/SpiralSpanningTreeCPP/spiral_spanning_tree_coverage_path_planner.py
Outdated
Show resolved
Hide resolved
PathPlanning/SpiralSpanningTreeCPP/spiral_spanning_tree_coverage_path_planner.py
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #355 +/- ##
=========================================
Coverage ? 89.51%
=========================================
Files ? 121
Lines ? 8660
Branches ? 0
=========================================
Hits ? 7752
Misses ? 908
Partials ? 0 Continue to review full report at Codecov.
|
Thanks @reso1 . I will merge it. |
Hi it's me again.
This is another CPP algorithm implementation,
proposed in Spiral-STC: An On-Line Coverage Algorithm of Grid Environments
by a Mobile Robot by Gabriely et.al.