Skip to content

Conversation

reso1
Copy link
Contributor

@reso1 reso1 commented Jul 9, 2020

Hi it's me again.
This is another CPP algorithm implementation,
proposed in Spiral-STC: An On-Line Coverage Algorithm of Grid Environments
by a Mobile Robot
by Gabriely et.al.

@coveralls
Copy link

coveralls commented Jul 9, 2020

Pull Request Test Coverage Report for Build 1507

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%

Totals Coverage Status
Change from base Build 1504: 0.0%
Covered Lines: 0
Relevant Lines: 0

💛 - Coveralls

@AtsushiSakai
Copy link
Owner

Thank you again!!

Copy link
Owner

@AtsushiSakai AtsushiSakai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some comments. PTAL

Copy link
Owner

@AtsushiSakai AtsushiSakai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating code. This is the last review. I will merge it after addressing my comments.

@codecov
Copy link

codecov bot commented Jul 12, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@7dd6b67). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #355   +/-   ##
=========================================
  Coverage          ?   89.51%           
=========================================
  Files             ?      121           
  Lines             ?     8660           
  Branches          ?        0           
=========================================
  Hits              ?     7752           
  Misses            ?      908           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7dd6b67...fb06dd6. Read the comment docs.

@AtsushiSakai AtsushiSakai merged commit 0c23ebe into AtsushiSakai:master Jul 12, 2020
@AtsushiSakai
Copy link
Owner

Thanks @reso1 . I will merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants