Skip to content

Conversation

FXCarl
Copy link
Contributor

@FXCarl FXCarl commented Feb 6, 2021

line 135, parent_index should be pind. other wise it cann't work

Reference issue

What does this implement/fix?

Additional information

parent_index should be pind. other wise it cann't work
Copy link
Owner

@AtsushiSakai AtsushiSakai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. If you have time, could you please add a test for this script under tests dir?
This test code helps you:
https://github.com/AtsushiSakai/PythonRobotics/blob/master/tests/test_a_star.py

@FXCarl
Copy link
Contributor Author

FXCarl commented Feb 21, 2021

I uploaded a test file, wish could help you

Copy link
Owner

@AtsushiSakai AtsushiSakai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!!

@AtsushiSakai AtsushiSakai merged commit c025299 into AtsushiSakai:master Feb 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants