-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
Add a Robot class for Move to Pose Algorithm #596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This pull request introduces 1 alert when merging adaabdd into bf4e682 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging a58dec4 into bf4e682 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging f536c77 into bf4e682 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging f332cbd into bf4e682 - view on LGTM.com new alerts:
|
docs/modules/control/move_to_a_pose_control/move_to_a_pose_control.rst
Outdated
Show resolved
Hide resolved
|
docs/modules/control/move_to_a_pose_control/move_to_a_pose_control.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Atsushi Sakai <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. This is the last review. After addressing these my comments, I will merge it.
@AtsushiSakai I think the whole move to pose code algorithm is in a great shape right now. I rename one file; added docstring comments; and updated the documentation. To expedite the process, I have two questions:
Thank you |
I'm not using any tool to remove trailing white spaces in comment/docstring texts. I will try to find a format tool for the issue.
Usually, you can check the latest doc in Circle CI result Ref |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the doc needs improvement, but the next PR is fine. Let's merge this PR. Thank you for your work!!
|
||
Ref: | ||
|
||
PathFinderController class |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[General comment] I think the rst doc should focus on the mathematics and the algorithm of the example. Documentation of codes should be in python script as docstrings or header comments. If you have time, please consider to fix the doc in the next PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AtsushiSakai Thanks for your comments. I agree to keep the rst doc only for the mathematical explanations. Also, it will be great if we can automatically generate a Reference document based on the docstrings comments. I will try to address your points in my next PR.
Merry Christmas and Happy new Year :)
What does this implement/fix?
Additional information
The advantage of this class is that you can define as many as robots with different specifications (name, color, controller and speed limitations)
CheckList