Skip to content

fix: added log of currentENU #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 29, 2021
Merged

fix: added log of currentENU #136

merged 2 commits into from
Apr 29, 2021

Conversation

github-actions[bot]
Copy link

No description provided.

aroller
aroller suggested changes Feb 26, 2021
View reviewed changes
Copy link

@aroller aroller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't currentENU logged by locator? Why log it here? We want to avoid coupling super with locator and most other nodes, even if only by message. Help me understand the goal here.

@danhennage
Copy link
Contributor

we need currentENU between roslaunch and when the flight plan starts. eventually we could get more sophisticated here and turn this off when the flight plan is executing.

aroller
aroller approved these changes Feb 26, 2021
View reviewed changes
Copy link

@aroller aroller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After discussion, this is ok to put here for now, but should be moved to locator to be published in a startup bag file that locator publishes on its own. Feel free to merge once it is proven to satisfy your needs and I'll relocate when ready.

@danhennage danhennage marked this pull request as ready for review April 28, 2021 23:44
@danhennage danhennage merged commit 4c450a8 into master Apr 29, 2021
@danhennage danhennage deleted the AM-677/culvert_alt branch April 29, 2021 16:25
@github-actions
Copy link
Author

🎉 This PR is included in version 9.3.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@aroller aroller aroller approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danhennage @aroller