Improve support for the gallery block #14
Conversation
…utomattic/gutenberg into improve/block-support
…utomattic/gutenberg into improve/block-support
| // Verify that the gallery block is ready to be synced. | ||
| // This means that, all images have had their blobs converted to full URLs. | ||
| // Checking for only the blobs ensures that blocks that have just been inserted work as well. | ||
| if ( 'core/gallery' === block.name ) { |
There was a problem hiding this comment.
I switched this from a switch case into an if statement just to keep it clean
ingeniumed
changed the title
|
|
||
| // Except the gallery block, all the other core blocks should be synced. | ||
| // We don't want anyone to override that, as that'll cause problems. | ||
| if ( block.name.startsWith( 'core/' ) ) { |
There was a problem hiding this comment.
@ingeniumed For non-core blocks, what happens when shouldBlockBeSynced() is false? Does only 1 user get the block?
There was a problem hiding this comment.
The idea would be that, none of the ydocs would have the block including the user who made the edit in Gutenberg. The block is considered to be "not ready to be synced" so it would be held off from being sent to all the ydocs. Presumably, whoever is using this filter would use it similar to the gallery block where after a certain condition is met it would be flipped to true and allowed to sync.
There'd def be a weird flicker where the block appears, vanishes as it's made "ready" and then shows up once its ready. But, it's better than the way the gallery block works now where you need to refresh the page.
All that said, I figured this would allow us to provide support for plugins that are out of our control or plugins like our own - RDB in their own way outside of gutenberg.
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
1 similar comment
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Noting as per our discussion that this will only target the gallery block. |
ingeniumed
merged commit f2dd14f
into
add/experimental-collaborative-editing
Description
The idea behind this PR is to improve the block support during the sync process between n clients. To start this, blocks are filtered out before they can be worked on to ensure unsupported blocks aren't synced.
The first case is the Gallery block. The images in a gallery are first uploaded as blobs, and then uploaded to WordPress. By filtering the block out until the upload process is done, it ensures that the block isn't in a broken state on any other client also working on the post. Once the upload process is done, the block's sync goes through and it appears correctly on all the clients working on the post.
I've kept this in draft state as I'd like to ensure this is a robust solution and that there aren't any other problems I haven't foreseen.