Skip to content

Allow post lock dialog to return and retain functionality #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pkevan merged 2 commits into from
Sep 23, 2025
Merged

Allow post lock dialog to return and retain functionality #32

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6be5b15
Allow post lock dialog to return and retain functionality
pkevan Sep 19, 2025
adbfa3f
add todo
pkevan Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/editor/src/components/post-locked-modal/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,10 @@ function PostLockedModal() {
return null;
}

if ( window.__experimentalEnableSync ) {
Copy link

@ingeniumed ingeniumed Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm trying to think about what this PR would look like when we want to get this into core. Would this change be accepted by the Gutenberg folks, given instead of doing window.<access flag here> they are adding a filter for plugin users? If it is accepted, what would it look like when we want to move it out of the experiment stage and have it be a core feature? How would null be returned then?

Copy link
Author

@pkevan pkevan Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would imagine it being either similar to the isLocked check directly above. Currently the override just short-circuits any logic in here, so either way, it would require refactor.

Copy link

@ingeniumed ingeniumed Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a todo about this? That way it's known and we have an idea of how to approach it?

return null;
}

const userDisplayName = user.name;
const userAvatar = user.avatar;

Expand Down
Loading