Replace fast-diff within Delta #43
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -1.53 kB (-0.08%) Total Size: 1.96 MB
ℹ️ View Unchanged
|
ingeniumed
commented
Oct 13, 2025
| // @ts-nocheck | ||
| /* eslint-env browser */ | ||
|
|
||
| import cloneDeep from 'lodash.clonedeep'; |
Author
There was a problem hiding this comment.
I haven't ported over the tests as they are in a different framework, and I wasn't 100% convinced on converting them. Tbh, I'm hoping the license issue works out and we have no need for this PR.
Member
That seems like a deal-breaker. |
Author
Noting that this convo is continuing internally. |
Author
|
Closing this PR as WordPress#72604 has been merged in with these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since the quill-delta library uses the Apache 2 license, while Gutenberg uses the GPL 2 license there may be a problem when we PR #41 into core. This change will swap the fast-diff library for the jsdiff library, as well as port the entire quill-delta package over so as to make the swapping easier.
The jsdiff has two major differences:
As we wait for legal's input on the licensing question, I'm leaving this in draft status as a backup plan.
The quill-delta test suite was really useful in seeing how seamless the swap could be. There was only one failure, related to the trivial semantic cleanup not existing. in that case, the end result was the same but fast-diff's result was what a human would do unlike the jsdiff one.
I'm going to keep testing it, to ensure I haven't missed any important difference.