-
Notifications
You must be signed in to change notification settings - Fork 862
Open
Labels
BugWhen a feature is broken and / or not performing as intendedWhen a feature is broken and / or not performing as intendedTriaged[Experiment] AI labels added[Focus] i18nInternationalization / i18n, adaptation to different languagesInternationalization / i18n, adaptation to different languages[Plugin] CRMIssues about the Jetpack CRM pluginIssues about the Jetpack CRM plugin[Pri] Normal[Status] Auto-allocated[Status] Escalated to Product Ambassadors[Status] Priority Review TriggeredThe guild in charge of triage has been notified of this issue in SlackThe guild in charge of triage has been notified of this issue in Slack
Description
Impacted plugin
CRM
Quick summary
- Main plugin file calls
ZeroBSCRM::instance()immediately, without waiting for init or similar hook ZeroBSCRM::__construct()callsZeroBSCRM::includes()- That method includes
ZeroBSCRM.Config.Init.php which calls__()`
In short, __() is called too early without waiting for init or similar. That's the prime example from the https://make.wordpress.org/core/2024/10/21/i18n-improvements-6-7/ post. This message means there are some __() calls in the plugin that won't ever work, which the developer should fix.
While this doing_it_wrong message was already introduced in 6.7, there were some edge cases where it didn't fire. In 6.8 that's not the case anymore. See https://make.wordpress.org/core/2025/03/12/i18n-improvements-6-8/
Steps to reproduce
- Update to WP 6.8
- Optionally change the site locale or user locale to e.g. de_DE
- Activate Jetpack CRM
- See doing_it_wrong message
Site owner impact
More than 60% of the total website/platform users
Severity
Minor
What other impact(s) does this issue have?
No response
If a workaround is available, please outline it here.
No response
Platform (Simple and/or Atomic)
No response
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
BugWhen a feature is broken and / or not performing as intendedWhen a feature is broken and / or not performing as intendedTriaged[Experiment] AI labels added[Focus] i18nInternationalization / i18n, adaptation to different languagesInternationalization / i18n, adaptation to different languages[Plugin] CRMIssues about the Jetpack CRM pluginIssues about the Jetpack CRM plugin[Pri] Normal[Status] Auto-allocated[Status] Escalated to Product Ambassadors[Status] Priority Review TriggeredThe guild in charge of triage has been notified of this issue in SlackThe guild in charge of triage has been notified of this issue in Slack
Type
Projects
Status
Backlog