Skip to content

Conversation

@jeherve
Copy link
Member

@jeherve jeherve commented Dec 21, 2018

Fixes #10730

Changes proposed in this Pull Request:

Testing instructions:

  • If you have a PHP 7.3 install, make sure you find no warnings in logs.

Proposed changelog entry for your changes:

  • PHP 7.3: fix warnings.

@jeherve jeherve added [Type] Bug When a feature is broken and / or not performing as intended [Status] Needs Review This PR is ready for review. [Type] Janitorial labels Dec 21, 2018
@jeherve jeherve added this to the 6.9 milestone Dec 21, 2018
@jeherve jeherve self-assigned this Dec 21, 2018
@jeherve jeherve requested review from a team and zinigor December 21, 2018 17:53
@matticbot
Copy link
Contributor

D22638-code. (newly created revision)

@jetpackbot
Copy link
Collaborator

jetpackbot commented Dec 21, 2018

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: January 10, 2019.
Scheduled code freeze: January 3, 2019

Generated by 🚫 dangerJS against 14b134f

Copy link
Contributor

@oskosk oskosk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@oskosk oskosk added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Dec 31, 2018
@oskosk oskosk merged commit 1bebf03 into master Dec 31, 2018
@oskosk oskosk deleted the fix/warnings-php73 branch December 31, 2018 15:15
@ghost ghost removed the [Status] Ready to Merge Go ahead, you can push that green button! label Dec 31, 2018
jeherve added a commit that referenced this pull request Jan 3, 2019
jeherve added a commit that referenced this pull request Jan 3, 2019
* Add first version of the Changelog and testing list for 6.9

* Changelog: add #10710

* changelog: add #10538

* changelog: add #10741

* changelog: add #10749

* changelog: add #10664

* changelog: add #10224

* changelog: add #10788

* Changelog: add #10560

* Chanegelog: add #10812

* changelog: add #10556

* Changelog: add #10668

* Changelog: add #10846

* Changelog: add #10947

* Changelog: add #10962

* Changelog: add #10956

* Changelog: add #10940

* Changelog: add #10934

* Changelog: add #10912

* changelog: add #10866

* changelog: add #10924

* Changelog: add #10936

* Changelog: add #10833

* changelog: add #10867

* Changelog: add #10960

* Changelog: add #10888

* changelog: add #10840

* changelog: add #10972

* Changelog: add #10979

* changelog: add #10909

* Changelog: add #10958

* Changelog: add #10981

* Changelog: add #10564

* Changelog: add #10809

* Changelog: add #10982

* Changelog: add #10706

* Changelog: add #10978

* Changelog: add #10132

* Changelog: add #11022

* Changelog: add #11024

* Changelog: add #10875

* Changelog: add #11030

* Changelog: add #11053

* Changelog: add #10880

* Changelog: add #9359

* Changelog: add #11037

* Update block list

* Changelog: add #11060

* Changelog: add #10755

* changelog: add #11000

* Changelog: add #10786

* Changelog: add #10945

* Changelog: add #10597
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Touches WP.com Files [Type] Bug When a feature is broken and / or not performing as intended [Type] Janitorial

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"continue" Warnings with PHP 7.3

5 participants