Skip to content

Conversation

@dereksmart
Copy link
Contributor

@dereksmart dereksmart commented Mar 20, 2019

This introduces a new set of default modules to play with.

Context p1HpG7-6qm-p2

Testing instructions:

Since these only kick in for new sites, Jurassic.ninja is kinda the only way.

https://jurassic.ninja/create?jetpack-beta&branch=update/default-modules&wp-debug-log

Proposed changelog entry for your changes:

N/A for now

@jetpackbot
Copy link
Collaborator

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: April 2, 2019.
Scheduled code freeze: March 26, 2019

Generated by 🚫 dangerJS against 337da31

@beaulebens
Copy link
Member

I'm going to leave a raw list of notes here of things I noticed when trying this out, which don't "fit the narrative", or which seems to pose an issue of some sort;

Pre Set Up

  • Connection banner says "You’re almost done. Set up Jetpack to boost your site performance and unlock powerful customization, marketing, and security tools."
  • On the pre-connection page, I think we should hide the Mobile Apps promo until they're set up. There's only one thing we want them to do at that point, and that's set up/connect Jetpack.

Set Up

  • Something weird going on here.

Screen Shot 2019-03-20 at 2 31 49 PM

- Plans grid was not focused on the security and performance offerings (although does mainly speak about those features).

Screen Shot 2019-03-20 at 2 33 13 PM

- I picked Premium (via credits) to see what the experience was like with a paid plan - We talk about "powering up" your site -- might be better to just be more direct and saying we're activating and configuring their paid features. - End of flow takes me back to wp-admin

After Set Up

  • I landed on My Plan within Jetpack, with the Jump start panel. Jump start didn't really stand out that much, and might be better off being highlighted somehow better?
  • Spacing between Jump start and the top box "Welcome to Jetpack Premium" was different to other spacing.

Screen Shot 2019-03-20 at 2 36 07 PM

- When I clicked around and got back to the Jetpack dashboard/At A Glance, I still got this JITM

Screen Shot 2019-03-20 at 2 36 47 PM

- Eventually I clicked the Jump start prompt to activate recommended features, without knowing what they were -- I think we should probably list/show/somehow explain right there what they're activating (and that it's all performance and security related). - Once I'd hit Jump start, I then got the dialog/overlay for the Premium Plan. We might want to reorganize that (and the Personal/Professional ones) to prioritize performance/security features.

Screen Shot 2019-03-20 at 2 38 18 PM

- I activated everything in that list and clicked "Got It" at the bottom. I'm now dropped on the dashboard with no stats, and no real idea on what to do next. It says it's security-scanning me, and that I'll be backed up soon. - "Plans" view in the plugin lists things other than security and performance. - "Plans" view in the plugin has a big "Introducing Premium Themes" banner/display at the top, which feels much less relevant now

Settings*

  • Incorrect capitalization, and extra spacing at the bottom of the card for "Plugin autoupdates"

Screen Shot 2019-03-20 at 2 42 58 PM

- Maybe move "Sitemaps", "Site verification", and "Stats" from Traffic to Performance? Or we might need a third settings section that catches some of the not-quite-perfect-fit pieces that we still want to ship. - There's no (obvious) way, other than digging to find the module list or using search (some of these don't show in search either) to interact with some features. Off the top of my head; Beautiful Math, Contact Form, Custom CSS, Extra Sidebar Widgets, Shortcode embeds, Tiled Galleries, WP.me Shortlinks, Widget visibility.

@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello dereksmart! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D25805-code before merging this PR. Thank you!

@beaulebens
Copy link
Member

Also note that I got 2 emails, neither of which mentioned security or performance. I think I got the Ads one only because I enabled ads, since they showed up in the overlay/dialog when I purchased Premium;

Screen Shot 2019-03-20 at 3 07 43 PM

Screen Shot 2019-03-20 at 3 07 30 PM

(I connected using an existing WP.com/testing account, so I didn't get an email about that).

@beaulebens
Copy link
Member

As a follow up to the above, I got another email -- this one focused on traffic generation, probably wants to be updated to talk about performance/security:

Screen Shot 2019-03-22 at 4 24 31 PM

Screen Shot 2019-03-22 at 4 24 41 PM

Screen Shot 2019-03-22 at 4 24 52 PM

@beaulebens
Copy link
Member

And another email talking about all the other features:

Screen Shot 2019-03-24 at 5 38 29 PM

Screen Shot 2019-03-24 at 5 38 36 PM

Screen Shot 2019-03-24 at 5 38 43 PM

@kraftbj kraftbj added this to the 7.3 milestone Mar 27, 2019
@eliorivero eliorivero force-pushed the update/default-modules branch from 337da31 to 11df884 Compare April 25, 2019 18:34
@eliorivero
Copy link
Contributor

I've rebased master to include the latest changes I introduced to auto activation as part of the module prioritization project (like widgets, widget-visibility and others) so changed files went from 16 to 11. I think this is good to go in the context of module prioritization.

Copy link
Contributor

@eliorivero eliorivero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐑

@jetpackbot
Copy link
Collaborator

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: May 7, 2019.
Scheduled code freeze: April 30, 2019

Generated by 🚫 dangerJS against 11df884

@eliorivero eliorivero added [Status] Ready to Merge Go ahead, you can push that green button! [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it and removed DO NOT MERGE don't merge it! [Status] In Progress labels Apr 25, 2019
@eliorivero eliorivero merged commit 7daa2f7 into master Apr 25, 2019
@eliorivero eliorivero deleted the update/default-modules branch April 25, 2019 18:50
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Touches WP.com Files [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants