Skip to content

Conversation

@jeherve
Copy link
Member

@jeherve jeherve commented Apr 16, 2019

Not ready for review yet. Waiting on D26821-code to land

Changes proposed in this Pull Request:

This is important for files that are currently in sync with WordPress.com,
where we don't include the Jetpack_AMP_Support class yet.

See D26821-code for more details.

Testing instructions:

Proposed changelog entry for your changes:

  • None

@jetpackbot
Copy link
Collaborator

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: May 7, 2019.
Scheduled code freeze: April 30, 2019

Generated by 🚫 dangerJS against 9e58acb

@jeherve jeherve removed the DO NOT MERGE don't merge it! label May 9, 2019
@jeherve jeherve added this to the 7.4 milestone May 9, 2019
@jeherve jeherve force-pushed the update/amp-checks branch 2 times, most recently from ad0d61c to 7a0abc9 Compare May 9, 2019 13:46
This is important for files that are currently in sync with WordPress.com,
where we don't include the Jetpack_AMP_Support class yet.

See D26821-code for more details.
@jetpackbot
Copy link
Collaborator

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: June 4, 2019.
Scheduled code freeze: May 28, 2019

Generated by 🚫 dangerJS against c5b3a13

@jeherve
Copy link
Member Author

jeherve commented May 9, 2019

Closing this now, this was done in #12140

@jeherve jeherve closed this May 9, 2019
@jeherve jeherve deleted the update/amp-checks branch May 9, 2019 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants