Skip to content

Conversation

@kraftbj
Copy link
Contributor

@kraftbj kraftbj commented May 9, 2019

Incomplete:

  • I'm not sure yet how to disable the form field and hide the key when using the constant (to match Akismet's behavior). We can't assume an administrator is supposed to be able to see the key.

Fixes #8226

Changes proposed in this Pull Request:

  • Use the API key as provided by Akismet (allows for a filter and a constant).
  • Needs UI to not render the form field if set via a constant (and maybe not show if using a filter?)

Is this a new feature or does it add/remove features to an existing part of Jetpack?

  • No.

Testing instructions:

Proposed changelog entry for your changes:

  • Admin Dashboard: Use Akismet API keys set with a constant or filter.

@kraftbj kraftbj added [Type] Bug When a feature is broken and / or not performing as intended [Status] In Progress Admin Page React-powered dashboard under the Jetpack menu labels May 9, 2019
@kraftbj kraftbj requested a review from a team May 9, 2019 20:50
@jetpackbot
Copy link
Collaborator

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: May 14, 2019.
Scheduled code freeze: May 7, 2019

Generated by 🚫 dangerJS against 95ccd95

@stale
Copy link

stale bot commented Aug 7, 2019

This PR has been marked as stale. This happened because:

  • It has been inactive in the past 3 months.
  • It hasn’t been labeled `[Pri] Blocker`, `[Pri] High`.

No further action is needed. But it's worth checking if this PR has clear testing instructions, is it up to date with master, and it is still valid. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.

@stale stale bot added the [Status] Stale label Aug 7, 2019
@kraftbj kraftbj removed the request for review from a team May 27, 2020 22:16
@stale stale bot removed the [Status] Stale label May 27, 2020
@kraftbj kraftbj self-assigned this May 27, 2020
@kraftbj kraftbj marked this pull request as draft May 27, 2020 22:16
@stale
Copy link

stale bot commented Aug 29, 2020

This PR has been marked as stale. This happened because:

  • It has been inactive in the past 3 months.
  • It hasn’t been labeled `[Pri] Blocker`, `[Pri] High`.

No further action is needed. But it's worth checking if this PR has clear testing instructions, is it up to date with master, and it is still valid. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.

@stale stale bot added the [Status] Stale label Aug 29, 2020
@jeherve
Copy link
Member

jeherve commented Aug 31, 2020

closing in favor of #16542.

@jeherve jeherve closed this Aug 31, 2020
@kraftbj kraftbj deleted the fix/akismet-key branch April 17, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Admin Page React-powered dashboard under the Jetpack menu [Type] Bug When a feature is broken and / or not performing as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UI doesn't handle Akismet keys set via constant properly

5 participants