Add Custom Autoloader #12447

enejb · 2019-05-23T08:14:12Z

This PR creates a custom autoloader package that could be used by a number of different plugins
to always load the latest version of the package libraries.

The Readme has more info.

This PR is a mash up of #12295 and https://github.com/schlessera/composer-wp-autoload/

Changes proposed in this Pull Request:

In this PR we create a new composer plugin that helps generate a few new files in the vender directory.

Is this a new feature or does it add/remove features to an existing part of Jetpack?

If you're an Automattician, include a shortlink to the p2 discussion with Jetpack Product here.

Testing instructions:

$ yarn docker:sh
$ cd /var/www/html/wp-content/plugins/jetpack/
$ composer install

Does the site still load as expected.

Test it actually loads the more up to date version of the package

first good luck
$ yarn docker:sh
Update Logo package version to 1.0.0
- add "version": "1.0.0" to packages/logo/composer.json inside the Jetpack plugin folder
Modify packages/logo/src/Logo.php
- Make it render something that is distinctive for this version
run composer install for wp-content/plugins/a/
Update Logo package version to 1.0.1
- add "version": "1.0.1" to packages/logo/composer.json inside the Jetpack plugin folder
Modify packages/logo/src/Logo.php
- Make it render something that is distinctive for this version
run composer install for wp-content/plugins/b/
activate both a and b
check that your site posts render the distinct 1.0.1 version of the package

Proposed changelog entry for your changes:

jetpackbot · 2019-05-23T08:16:12Z

	Warnings
⚠️	Consider adding new PHP files to PHPCS whitelist for automatic linting: docker/wordpress/wp-content/plugins/a/a.php docker/wordpress/wp-content/plugins/b/b.php

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS against b75cdc9

lezama · 2019-05-23T14:08:48Z

I like where this is going

composer.json

tyxla

Nice work here, Enej!

I wonder if we can get rid of a bunch of code, considering we no longer care about PHP 5.2.

tyxla · 2019-05-23T14:10:45Z

packages/autoloader/composer.json

+	"description": "An autoloader for Jetpack packages",
+	"type": "library",
+	"license": "GPL-2.0-or-later",
+	"version": "1.0.0",


Do we need a specific version here, or can we rely on the tags instead (like we're planning to do for the other packages)

I am not sure how to make it work without a version here.
I run into error when I start with an empty vendor directory.

That makes sense, but it's a bug indeed. #12480 resolves that - it should unblock this once it lands.

The problem is that Composer needs a version when with the stable minimum stability constraint. But in #12480 we suggest to lower the minimum stability constraint to @dev, as it'll unblock us in our goal to always use the local package in Jetpack (be it for development or for production).

packages/autoloader/src/AutoloadGenerator.php

packages/autoloader/src/autoload.php

packages/autoloader/src/AutoloadGenerator.php

packages/autoloader/src/autoload.php

gravityrail · 2019-05-23T20:29:19Z

This is a really interesting approach. Definitely keep pushing in this direction.

gravityrail · 2019-05-23T20:33:06Z

Relevant to https://github.com/Automattic/jpop-issues/issues/3897

docker/wordpress/wp-content/plugins/a/a.php

packages/autoloader/src/AutoloadGenerator.php

packages/autoloader/README.md

composer.json

.gitignore

composer.json

docker/wordpress/wp-content/plugins/a/a.php

docker/wordpress/wp-content/plugins/a/composer.json

packages/autoloader/README.md

packages/autoloader/src/AutoloadGenerator.php

jeherve

This does not seem to work for me.

When I try to activate the test plugin, I get the following:

PHP Warning:  require(/var/www/html/wp-content/plugins/a/vendor/autoload.php): failed to open stream: No such file or directory in /var/www/html/wp-content/plugins/a/a.php on line 8

I tried to do the following:

yarn docker:sh
cd /var/www/html/wp-content/plugins/a
composer install

And got the following error:

/var/www/html/wp-content/plugins/a# composer install
You are running composer with xdebug enabled. This has a major impact on runtime performance. See https://getcomposer.org/xdebug
Loading composer repositories with package information
Installing dependencies (including require-dev) from lock file


  [ErrorException]
  "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"?


install [--prefer-source] [--prefer-dist] [--dry-run] [--dev] [--no-dev] [--no-plugins] [--no-custom-installers] [--no-autoloader] [--no-scripts] [--no-progress] [-v|vv|vvv|--verbose] [-o|--optimize-autoloader] [-a|--classmap-authoritative] [--ignore-platform-reqs] [--] [<packages>]...

I tried to rm composer.lock and then run composer install again, but that did not help.

packages/autoloader/README.md

lezama · 2019-05-27T20:27:37Z

NOTE: found that we can run composer install --no-autoloader to avoid generating composer autoloaders.

packages/autoloader/src/AutoloadGenerator.php

lezama · 2019-05-28T00:30:19Z

packages/autoloader/src/AutoloadGenerator.php

+	 *
+	 * @param bool $classMapAuthoritative
+	 */
+	public function setClassMapAuthoritative( $classMapAuthoritative ) {


could we remove this method? I think it doesn't differ from the parent

jeherve · 2019-05-28T08:54:10Z

Will this do anything as it stands right now, since it's not called from jetpack.php instead of the default autoloader?

gravityrail

I am ok with merging this so we have time to refine it before the next Jetpack release. Thank you @enejb for the amazing work on this!

enejb · 2019-05-30T21:02:06Z

Some of the changes that @lezama and I worked on. At the end were

🚤 Removing the filter to block/skip loading a file. Right now there is no need for this I added it as a precaution. But really there is no need.
📛 Added a namespace to the autoloader.php. Since everything should be namespaced.
📛 Named the autoloader a function so that it can be more easily unregistered if need be.
🎉 Greatly simplified the generator.
✅ Test were added so that we have some assurance that the 2 methods work as expected.

Removed the un necessery gitignore lines.

@enejb

* Add Custom Autoloader (#12447) * Try Custom Autoloader * spelling fix Co-Authored-By: Marin Atanasov <[email protected]> * minor space fix Co-Authored-By: Marin Atanasov <[email protected]> * minor space fix. Co-Authored-By: Marin Atanasov <[email protected]> * Updated to make it even simpler * test plugin * a Toy plugin :) 🚂 * Minor update * Minor update * Fixes typo * delete file * Minor updates * Added limitaionts section to readme * ooops * Fix readme * Turn the jetpack-autoloader into a package. * fixes to the jetpack a custom plugin * typo Co-Authored-By: Marin Atanasov <[email protected]> * remove scripts to "a" no longer needed thanks to @enejb magic * Update packages/autoloader/README.md fixes more wording in the readme Co-Authored-By: Miguel Lezama <[email protected]> * Update the version numbers of packages insead of branches * forgot about the plugin * update "a" composer * Update the a composer lock file. * Revert "Update the a composer lock file." This reverts commit 90f2cb8dbc50e15caf19fa0b88e1ee201f8f21c5. * typo fix Co-Authored-By: Miguel Lezama <[email protected]> * Rebased against master, testes that a plugin works as expected * Remove not needed code * Minor readme fix * Remoce Space * Add filter to prevent the autoloader from loading a particular version * add b toy plugin depending on Jetpack Logo 1.0.1 Co-Authored-By: Marin Atanasov <[email protected]> * minor space fix Co-Authored-By: Miguel Lezama <[email protected]> * Update a comment * Fix phpcs fixes * Make the remove class_map from the global name space, fix phpcs issues * Add the autoload_packages to be ignored. * Add debug info * Remove versions from composer.json of packages * Add missing vendor to namespace * Fix typo * Fix typo and add punctuation * Fix a typo * Update .gitignore Co-Authored-By: Jeremy Herve <[email protected]> * Update all the composer files * Take into account the @dev and always use the dev-* version * Bug Fix load the latest version! * Update the logic when enqueing the classes * Update to use Namespaces * Add tests to make sure that the enqueing works as expected * Fix suggestions from Marin * Remove generateClassMap method * Fix the tests, rename the fucntion name to be more accurate * More fixes to the tests. * FuN * Making it all work again * Update the lock file * Minor * Remove unused plugins (#12529) * Removed unnecessary gitignore lines. * Separate the connection library into its own package. (#12399) * Added an interface as a guide for the new package methods. * Add package structure * Initialized the composer library, added gitignore. * Removed phpunit from connection dependencies. * Added first real code to the connection manager class, as well as tests for it. * Renamed the test folder to tests. * Made the option name be a class constant. * Added 10up's WP_Mock as a dependency, refactored the injection to use filters instead of setters. * Changed the internal method accessibility to protected. * Initialized an empty package repo for the options manager. * Added the options package as a dependency to the master repo. * Added a package structure placeholder for the options manager. * Added the first test for the delete option method. * Added the update method and a test for it. * Added a test for the grouped option deletion. * Added the group updater method and a test for it. * Added the grouped option getter and a test for it. * Added a test for the noncompact option getter. * Added tests for network option manipulation. * Removed autoloader requirement in favour of the existing one. * Added the connection manager secret generator to actual Jetpack class. * Removed individual gitignore files in favor of a parent-level file, props @tyxla! * Moved packages source code into src folders. * Removed the V7 part of the namespace. * Remove v7 from namespace in the Manager Interface * Remove V7 from namespaces * Add Automattic to the namespace * Rename jetpack-[name] packages to [name] * Update composer lock * Adding a package for Jetpack Constants * Attempting to fix WPCOM tests. * Excluding packages folder from linting for PHP 5.6 and earlier. * adjust syntax in connection tests * removing new unit tests. i'm not sure why they are failing. we can re-add them later. * reverting last commit, and fixing tests in `packages/options` * ah, one more * remove an un-needed linting hack (#12543) * Composer: avoid duplicate repositories key (#12546) * Composer: avoid duplicate repositories key Rely on wildcard instead. See #12483 * Revert changes in composer.lock * Revert changes in composer.lock * Revert changes in composer.lock * Packages: Make logo package tests independent (#12514) * Move package tests to package directory * Add some dev deps to logo package * Ignore vendor of all packages * Add a logo package simple bootstrap * Add a logo package phpunit config * Cleanup package tests from Jetpack phpunit config * Remove WP prefix from class name * Make sure composer is installed * Try: add SCOPE to travis matrix * Try: Disable older PHP versions * Replace WP_Mock with PHPMock * Enable php 7.0 in Travis again * Make phpunit version more permissive * Fix setUp signature * Play with phpunit versions * Try enabling CI for feature branch * Try enabling CI for feature branch * Try enabling CI for feature branch * Revert latest changes * Try adding the branch to the whitelist * Enable PHP 5.6 again * Use php-mock instead of php-mock-phpunit * Run composer phpunit for all packages * Make mocking method protected * Add parent teardown * Remove whitelisted branch * Run only for packages with tests * remove trailing slash 🤔 * nope * not sure what I am doing * add debug statements * run only if we have `php` tests @zinigor @tyxla we need to normalise de connection one * Jetpack Options Package: just class map existing options class (#12562) * instead of a new implementation of jetpack options, let's class map it * Packages: Fix connection tests and allow them to run in CI (#12560) * Use php-mock instead of wp_mock * Add phpunit script * Migrate tests from wp_mock to phpmock * Make tests run in CI * Run travis only for packages that have the php test dir * Revert "Jetpack Options Package: just class map existing options class (#12562)" (#12571) This reverts commit 0e3ac7a. * Packages: Finish the constants package (#12558) * PSR-4 constants * Actually add namespacing to the constants class * Update composer.lock * Fix phpcs errors and add some docs * Add a package README * Move constant tests to the package * Update Jetpack to use the constants package * Fix constants usage in options package * Rename README variable Co-Authored-By: Miguel Lezama <[email protected]> * Fix typo Co-Authored-By: Miguel Lezama <[email protected]> * Use plural Co-Authored-By: Miguel Lezama <[email protected]> * Making Jetpack_Options a classmapped package. (#12577) * Making Jetpack_Options a classmapped package. * Update Jetpack to use new JITM package (#12516) * Update Jetpack to use new JITM package * Add instructions on package installation and usage (#12576) * Add instructions on package installation and usage * Move content about installing Composer to the doc regarding development environment. Add a pointer to that section in the packages' readme * Explain how to install Composer on systems other than macOS. Props @aldavigdis * Update docs/development-environment.md Co-Authored-By: Jeremy Herve <[email protected]> * Apply suggestions from code review Co-Authored-By: Jeremy Herve <[email protected]> * Add reference to Composer installation in the section that explains how to start developing for Jetpack * Packages: Fix alias example in README (#12582) * Packages: Move sync to a classmapped package (#12572) * Move all sync files to the package * Add sync package composer.json * Composer require the new sync package * Update composer.lock after adding sync package dependency * Remove some sync file requiring in sync package * Remove some sync file requiring in the rest of Jetpack * Hook Jetpack actions properly * Fix a rebase conflict * Fix update post terms test to not compare against the DB * Packages: Move JITM tests to package and fix deps (#12583) * Add phpunit devdep and composer phpunit script * Add JITM tests config * Move tests and add bootstrap * Remove legacy jitm suite * Rely on @dev connection package * Remove version * Update minimum stability and prefer stable * Fix tests * Update composer.lock * Fix whitespace Co-Authored-By: Miguel Lezama <[email protected]> * Prepend an empty line Co-Authored-By: Miguel Lezama <[email protected]> * Connection Package: add Jetpack_Data methods (#12580) Jetpack_Data -> Connection package * removes php_bug_66229_check method - it's no longer used in the code base. * Moving is_usable_domain to Connection package. * Moves `get_access_token` to Connection package. * Create package for Jetpack Tracking (#12596) Created package for Jetpack Tracking * Update/package logo add gray (#12610) * Update the logo package to include a gray version. Add parameter to render method to specify the type * Remove svg files. Update method to return an SVG string that can be stylized with CSS. Update tests. * Fixed issue with logo in Jetpack connection banner in WP Admin * Update test so it strictly tests two instances of the CSS class * Optimize performance. Use const since the string is immutable. Use nowdoc to compose the string. * Update logo tests in new file * Constants_Manager -> Constants * inc/lib/admin-pages/class.jetpack-react-page.php (#12627) * Add jetpack signature class to connection package (#12620) * Connection package: Add class.jetpack-signature and class.jetpack-error to connection package * DNA: Don't require composer autoloader (#12624) * Jitm package, don't use global Jetpack class (#12629)

@enejb

* Try Custom Autoloader * spelling fix Co-Authored-By: Marin Atanasov <[email protected]> * minor space fix Co-Authored-By: Marin Atanasov <[email protected]> * minor space fix. Co-Authored-By: Marin Atanasov <[email protected]> * Updated to make it even simpler * test plugin * a Toy plugin :) 🚂 * Minor update * Minor update * Fixes typo * delete file * Minor updates * Added limitaionts section to readme * ooops * Fix readme * Turn the jetpack-autoloader into a package. * fixes to the jetpack a custom plugin * typo Co-Authored-By: Marin Atanasov <[email protected]> * remove scripts to "a" no longer needed thanks to @enejb magic * Update packages/autoloader/README.md fixes more wording in the readme Co-Authored-By: Miguel Lezama <[email protected]> * Update the version numbers of packages insead of branches * forgot about the plugin * update "a" composer * Update the a composer lock file. * Revert "Update the a composer lock file." This reverts commit 90f2cb8dbc50e15caf19fa0b88e1ee201f8f21c5. * typo fix Co-Authored-By: Miguel Lezama <[email protected]> * Rebased against master, testes that a plugin works as expected * Remove not needed code * Minor readme fix * Remoce Space * Add filter to prevent the autoloader from loading a particular version * add b toy plugin depending on Jetpack Logo 1.0.1 Co-Authored-By: Marin Atanasov <[email protected]> * minor space fix Co-Authored-By: Miguel Lezama <[email protected]> * Update a comment * Fix phpcs fixes * Make the remove class_map from the global name space, fix phpcs issues * Add the autoload_packages to be ignored. * Add debug info * Remove versions from composer.json of packages * Add missing vendor to namespace * Fix typo * Fix typo and add punctuation * Fix a typo * Update .gitignore Co-Authored-By: Jeremy Herve <[email protected]> * Update all the composer files * Take into account the @dev and always use the dev-* version * Bug Fix load the latest version! * Update the logic when enqueing the classes * Update to use Namespaces * Add tests to make sure that the enqueing works as expected * Fix suggestions from Marin * Remove generateClassMap method * Fix the tests, rename the fucntion name to be more accurate * More fixes to the tests. * FuN * Making it all work again * Update the lock file * Minor

@enejb

* Add Custom Autoloader (#12447) * Try Custom Autoloader * spelling fix Co-Authored-By: Marin Atanasov <[email protected]> * minor space fix Co-Authored-By: Marin Atanasov <[email protected]> * minor space fix. Co-Authored-By: Marin Atanasov <[email protected]> * Updated to make it even simpler * test plugin * a Toy plugin :) 🚂 * Minor update * Minor update * Fixes typo * delete file * Minor updates * Added limitaionts section to readme * ooops * Fix readme * Turn the jetpack-autoloader into a package. * fixes to the jetpack a custom plugin * typo Co-Authored-By: Marin Atanasov <[email protected]> * remove scripts to "a" no longer needed thanks to @enejb magic * Update packages/autoloader/README.md fixes more wording in the readme Co-Authored-By: Miguel Lezama <[email protected]> * Update the version numbers of packages insead of branches * forgot about the plugin * update "a" composer * Update the a composer lock file. * Revert "Update the a composer lock file." This reverts commit 90f2cb8dbc50e15caf19fa0b88e1ee201f8f21c5. * typo fix Co-Authored-By: Miguel Lezama <[email protected]> * Rebased against master, testes that a plugin works as expected * Remove not needed code * Minor readme fix * Remoce Space * Add filter to prevent the autoloader from loading a particular version * add b toy plugin depending on Jetpack Logo 1.0.1 Co-Authored-By: Marin Atanasov <[email protected]> * minor space fix Co-Authored-By: Miguel Lezama <[email protected]> * Update a comment * Fix phpcs fixes * Make the remove class_map from the global name space, fix phpcs issues * Add the autoload_packages to be ignored. * Add debug info * Remove versions from composer.json of packages * Add missing vendor to namespace * Fix typo * Fix typo and add punctuation * Fix a typo * Update .gitignore Co-Authored-By: Jeremy Herve <[email protected]> * Update all the composer files * Take into account the @dev and always use the dev-* version * Bug Fix load the latest version! * Update the logic when enqueing the classes * Update to use Namespaces * Add tests to make sure that the enqueing works as expected * Fix suggestions from Marin * Remove generateClassMap method * Fix the tests, rename the fucntion name to be more accurate * More fixes to the tests. * FuN * Making it all work again * Update the lock file * Minor * Remove unused plugins (#12529) * Removed unnecessary gitignore lines. * Separate the connection library into its own package. (#12399) * Added an interface as a guide for the new package methods. * Add package structure * Initialized the composer library, added gitignore. * Removed phpunit from connection dependencies. * Added first real code to the connection manager class, as well as tests for it. * Renamed the test folder to tests. * Made the option name be a class constant. * Added 10up's WP_Mock as a dependency, refactored the injection to use filters instead of setters. * Changed the internal method accessibility to protected. * Initialized an empty package repo for the options manager. * Added the options package as a dependency to the master repo. * Added a package structure placeholder for the options manager. * Added the first test for the delete option method. * Added the update method and a test for it. * Added a test for the grouped option deletion. * Added the group updater method and a test for it. * Added the grouped option getter and a test for it. * Added a test for the noncompact option getter. * Added tests for network option manipulation. * Removed autoloader requirement in favour of the existing one. * Added the connection manager secret generator to actual Jetpack class. * Removed individual gitignore files in favor of a parent-level file, props @tyxla! * Moved packages source code into src folders. * Removed the V7 part of the namespace. * Remove v7 from namespace in the Manager Interface * Remove V7 from namespaces * Add Automattic to the namespace * Rename jetpack-[name] packages to [name] * Update composer lock * Adding a package for Jetpack Constants * Attempting to fix WPCOM tests. * Excluding packages folder from linting for PHP 5.6 and earlier. * adjust syntax in connection tests * removing new unit tests. i'm not sure why they are failing. we can re-add them later. * reverting last commit, and fixing tests in `packages/options` * ah, one more * remove an un-needed linting hack (#12543) * Composer: avoid duplicate repositories key (#12546) * Composer: avoid duplicate repositories key Rely on wildcard instead. See #12483 * Revert changes in composer.lock * Revert changes in composer.lock * Revert changes in composer.lock * Packages: Make logo package tests independent (#12514) * Move package tests to package directory * Add some dev deps to logo package * Ignore vendor of all packages * Add a logo package simple bootstrap * Add a logo package phpunit config * Cleanup package tests from Jetpack phpunit config * Remove WP prefix from class name * Make sure composer is installed * Try: add SCOPE to travis matrix * Try: Disable older PHP versions * Replace WP_Mock with PHPMock * Enable php 7.0 in Travis again * Make phpunit version more permissive * Fix setUp signature * Play with phpunit versions * Try enabling CI for feature branch * Try enabling CI for feature branch * Try enabling CI for feature branch * Revert latest changes * Try adding the branch to the whitelist * Enable PHP 5.6 again * Use php-mock instead of php-mock-phpunit * Run composer phpunit for all packages * Make mocking method protected * Add parent teardown * Remove whitelisted branch * Run only for packages with tests * remove trailing slash 🤔 * nope * not sure what I am doing * add debug statements * run only if we have `php` tests @zinigor @tyxla we need to normalise de connection one * Jetpack Options Package: just class map existing options class (#12562) * instead of a new implementation of jetpack options, let's class map it * Packages: Fix connection tests and allow them to run in CI (#12560) * Use php-mock instead of wp_mock * Add phpunit script * Migrate tests from wp_mock to phpmock * Make tests run in CI * Run travis only for packages that have the php test dir * Revert "Jetpack Options Package: just class map existing options class (#12562)" (#12571) This reverts commit 0e3ac7a. * Packages: Finish the constants package (#12558) * PSR-4 constants * Actually add namespacing to the constants class * Update composer.lock * Fix phpcs errors and add some docs * Add a package README * Move constant tests to the package * Update Jetpack to use the constants package * Fix constants usage in options package * Rename README variable Co-Authored-By: Miguel Lezama <[email protected]> * Fix typo Co-Authored-By: Miguel Lezama <[email protected]> * Use plural Co-Authored-By: Miguel Lezama <[email protected]> * Making Jetpack_Options a classmapped package. (#12577) * Making Jetpack_Options a classmapped package. * Update Jetpack to use new JITM package (#12516) * Update Jetpack to use new JITM package * Add instructions on package installation and usage (#12576) * Add instructions on package installation and usage * Move content about installing Composer to the doc regarding development environment. Add a pointer to that section in the packages' readme * Explain how to install Composer on systems other than macOS. Props @aldavigdis * Update docs/development-environment.md Co-Authored-By: Jeremy Herve <[email protected]> * Apply suggestions from code review Co-Authored-By: Jeremy Herve <[email protected]> * Add reference to Composer installation in the section that explains how to start developing for Jetpack * Packages: Fix alias example in README (#12582) * Packages: Move sync to a classmapped package (#12572) * Move all sync files to the package * Add sync package composer.json * Composer require the new sync package * Update composer.lock after adding sync package dependency * Remove some sync file requiring in sync package * Remove some sync file requiring in the rest of Jetpack * Hook Jetpack actions properly * Fix a rebase conflict * Fix update post terms test to not compare against the DB * Packages: Move JITM tests to package and fix deps (#12583) * Add phpunit devdep and composer phpunit script * Add JITM tests config * Move tests and add bootstrap * Remove legacy jitm suite * Rely on @dev connection package * Remove version * Update minimum stability and prefer stable * Fix tests * Update composer.lock * Fix whitespace Co-Authored-By: Miguel Lezama <[email protected]> * Prepend an empty line Co-Authored-By: Miguel Lezama <[email protected]> * Connection Package: add Jetpack_Data methods (#12580) Jetpack_Data -> Connection package * removes php_bug_66229_check method - it's no longer used in the code base. * Moving is_usable_domain to Connection package. * Moves `get_access_token` to Connection package. * Create package for Jetpack Tracking (#12596) Created package for Jetpack Tracking * Update/package logo add gray (#12610) * Update the logo package to include a gray version. Add parameter to render method to specify the type * Remove svg files. Update method to return an SVG string that can be stylized with CSS. Update tests. * Fixed issue with logo in Jetpack connection banner in WP Admin * Update test so it strictly tests two instances of the CSS class * Optimize performance. Use const since the string is immutable. Use nowdoc to compose the string. * Update logo tests in new file * Constants_Manager -> Constants * inc/lib/admin-pages/class.jetpack-react-page.php (#12627) * Add jetpack signature class to connection package (#12620) * Connection package: Add class.jetpack-signature and class.jetpack-error to connection package * DNA: Don't require composer autoloader (#12624) * Jitm package, don't use global Jetpack class (#12629)

enejb requested a review from a team May 23, 2019 08:14

enejb added this to the 7.4 milestone May 23, 2019

enejb added the [Status] In Progress label May 23, 2019

enejb self-assigned this May 23, 2019

enejb requested a review from a team May 23, 2019 08:19

jeherve added the [Focus] Jetpack DNA label May 23, 2019

lezama reviewed May 23, 2019

View reviewed changes

composer.json Outdated Show resolved Hide resolved

tyxla reviewed May 23, 2019

View reviewed changes

enejb added [Status] Needs Review This PR is ready for review. and removed [Status] In Progress labels May 24, 2019

lezama requested a review from griffbrad May 24, 2019 23:10

enejb commented May 25, 2019

View reviewed changes

docker/wordpress/wp-content/plugins/a/a.php Outdated Show resolved Hide resolved

jeherve requested changes May 27, 2019

View reviewed changes

docker/wordpress/wp-content/plugins/a/a.php Show resolved Hide resolved

packages/autoloader/src/AutoloadGenerator.php Outdated Show resolved Hide resolved

packages/autoloader/README.md Outdated Show resolved Hide resolved

jeherve added [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. and removed [Status] Needs Review This PR is ready for review. labels May 27, 2019

tyxla reviewed May 27, 2019

View reviewed changes

jeherve reviewed May 27, 2019

View reviewed changes

lezama reviewed May 27, 2019

View reviewed changes

packages/autoloader/README.md Outdated Show resolved Hide resolved

enejb force-pushed the try/custom-autoloader branch from ffbacef to 5ab5eae Compare May 27, 2019 21:38

enejb added [Status] Needs Review This PR is ready for review. and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels May 27, 2019

lezama reviewed May 28, 2019

View reviewed changes

packages/autoloader/src/AutoloadGenerator.php Outdated Show resolved Hide resolved

lezama reviewed May 28, 2019

View reviewed changes

packages/autoloader/src/AutoloadGenerator.php Outdated Show resolved Hide resolved

lezama reviewed May 28, 2019

View reviewed changes

enejb added 7 commits May 29, 2019 15:00

Update to use Namespaces

60de3a7

Add tests to make sure that the enqueing works as expected

844384d

Fix suggestions from Marin

baedcd8

Remove generateClassMap method

b37bdc7

Fix the tests, rename the fucntion name to be more accurate

3d3bc81

More fixes to the tests.

bd55149

FuN

741938a

gravityrail previously approved these changes May 30, 2019

View reviewed changes

Making it all work again

293ff06

enejb dismissed gravityrail’s stale review via 293ff06 May 30, 2019 20:54

enejb added 2 commits May 30, 2019 14:31

Update the lock file

7c840b4

Minor

b75cdc9

roccotripaldi changed the base branch from master to feature/jetpack-packages May 31, 2019 19:57

dereksmart changed the title ~~Try Custom Autoloader~~ Add Custom Autoloader May 31, 2019

dereksmart force-pushed the feature/jetpack-packages branch from 7a4d3f3 to 7df90c1 Compare May 31, 2019 20:27

roccotripaldi merged commit a652a24 into feature/jetpack-packages May 31, 2019

matticbot added [Status] Needs Changelog and removed [Status] Needs Review This PR is ready for review. labels May 31, 2019

gravityrail mentioned this pull request May 31, 2019

Fix/conflicting libraries loaded case #12295

Closed

roccotripaldi mentioned this pull request May 31, 2019

Feature/jetpack packages (May 31 - June 6) #12527

Merged

enejb added a commit that referenced this pull request May 31, 2019

More clean up from (#12447)

9e1d02d

Removed the un necessery gitignore lines.

enejb mentioned this pull request May 31, 2019

More clean up from (#12447) #12530

Merged

dereksmart mentioned this pull request Jun 10, 2019

Feature/jetpack packages pt 1. (May 31 - June 6) #12637

Merged

jeherve removed [Status] Needs Changelog labels Jun 17, 2019

lezama deleted the try/custom-autoloader branch June 27, 2019 14:50

Add Custom Autoloader #12447

Add Custom Autoloader #12447

Uh oh!

Conversation

enejb commented May 23, 2019 • edited by lezama Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes proposed in this Pull Request:

Is this a new feature or does it add/remove features to an existing part of Jetpack?

Testing instructions:

Proposed changelog entry for your changes:

Uh oh!

jetpackbot commented May 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lezama commented May 23, 2019

Uh oh!

Uh oh!

tyxla left a comment

Choose a reason for hiding this comment

Uh oh!

tyxla May 23, 2019

Choose a reason for hiding this comment

Uh oh!

enejb May 28, 2019

Choose a reason for hiding this comment

Uh oh!

tyxla May 29, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gravityrail commented May 23, 2019

Uh oh!

gravityrail commented May 23, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jeherve left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

lezama commented May 27, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lezama May 28, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

enejb May 28, 2019

Choose a reason for hiding this comment

Uh oh!

jeherve commented May 28, 2019

Uh oh!

gravityrail left a comment

Choose a reason for hiding this comment

Uh oh!

enejb commented May 30, 2019

Uh oh!

Reviewers

Assignees

Labels

enejb commented May 23, 2019 •

edited by lezama

Loading

jetpackbot commented May 23, 2019 •

edited

Loading

lezama commented May 27, 2019 •

edited

Loading

lezama May 28, 2019 •

edited

Loading