Skip to content

Connect flow: remove post-disconnect survey #12458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jeherve merged 1 commit into from
May 24, 2019
Merged

Connect flow: remove post-disconnect survey #12458

jeherve merged 1 commit into from
May 24, 2019

Conversation

@jeherve
Copy link
Member

@jeherve jeherve commented May 23, 2019

Fixes #12452

Changes proposed in this Pull Request:

This survey is not displayed to users since #10888, so there is really no need to keep this around.

Testing instructions:

  • Go to Jetpack > Dashboard
  • Scroll down to the connection area
  • Disconnect your site from WordPress.com.
  • Upon disconnecting, there will be a flash on the page before the connection modal appears again. Before the modal appears again, you should not see any notice about the disconnection survey.

Proposed changelog entry for your changes:

  • None

@jeherve
Connect flow: remove post-disconnect survey
972841e 
Fixes #12452

This survey is not displayed to users since #10888, so there is really no need to keep this around.
@jeherve jeherve added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review This PR is ready for review. Admin Page React-powered dashboard under the Jetpack menu [Pri] Low labels May 23, 2019
@jeherve jeherve requested review from a team and dereksmart May 23, 2019 21:22
@jeherve jeherve self-assigned this May 23, 2019
@jetpackbot
Copy link
Collaborator

jetpackbot commented May 23, 2019

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: June 4, 2019.
Scheduled code freeze: May 28, 2019

Generated by 🚫 dangerJS against 972841e

@kraftbj kraftbj added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels May 24, 2019
@jeherve jeherve added this to the 7.4 milestone May 24, 2019
@jeherve jeherve merged commit 69b4b41 into master May 24, 2019
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels May 24, 2019
@jeherve jeherve deleted the rm/disconnect-survey branch May 24, 2019 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kraftbj kraftbj kraftbj approved these changes

@dereksmart dereksmart Awaiting requested review from dereksmart

Assignees

@jeherve jeherve

Labels

Admin Page React-powered dashboard under the Jetpack menu [Pri] Low [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Projects

None yet

Milestone

7.4

Development

Successfully merging this pull request may close these issues.

"Why are you disconnecting" modal is shown and then is immediately hidden

5 participants

@jeherve @jetpackbot @kraftbj @matticbot