Sync: Move to an independent package #12524
Conversation
tyxla
added
[Status] In Progress
[Package] Sync
DO NOT MERGE
|
Thank you for the great PR description! When this PR is ready for review, please apply the Scheduled Jetpack release: June 4, 2019. |
| "require": {}, | ||
| "autoload": { | ||
| "psr-4": { | ||
| "Automattic\\Jetpack\\Sync\\": "src/" |
There was a problem hiding this comment.
It doesn't seem like there is a src folder in this package. How does this work?
There was a problem hiding this comment.
Yeah, I had that locally, but didn't end up committing it 😉 It's in the branch now.
| * This is used to provide compression and serialization to messages | ||
| **/ | ||
| interface iJetpack_Sync_Codec { | ||
| interface Codec { |
There was a problem hiding this comment.
I think we should suffix interfaces with Interface. So that it is more clear that we are implementing one.
There was a problem hiding this comment.
I like that, I'll keep it in mind for the next iteration 👍
dereksmart
force-pushed
the
feature/jetpack-packages
branch
from
7a4d3f3 to
7df90c1
Compare
packages/sync/Module_Full_Sync.php
Outdated
|
|
||
| foreach ( Jetpack_Sync_Modules::get_modules() as $module ) { | ||
| foreach ( Modules::get_modules() as $module ) { | ||
| Jetpack_Options::delete_raw_option( "{$prefix}_{$module->name()}_sent" ); |
There was a problem hiding this comment.
Yeah, I think we should take care of those first, and then start on the sync one.
|
Folks, I'm going to close this PR as it has grown too huge. Going to take it in smaller steps, but also will make sure that the important packages that sync needs (options, constants, etc.) have landed as separate packages already. In the next iteration also consider the suggestions everyone here has made. Thanks! |
WIP. This PR aims to move all of Sync to a separate, independent package.
Note: this is far from ready to test or use right now. Tests and coding standards need some ❤️
Changes proposed in this Pull Request:
Is this a new feature or does it add/remove features to an existing part of Jetpack?
Testing instructions:
Proposed changelog entry for your changes: